feat(entities): support terraform in config card [khcp-12445] #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaiarrowood
changed the title
kaiarrowood
commented
Aug 9, 2024
...ges/entities/entities-shared/src/components/entity-base-config-card/EntityBaseConfigCard.vue
Outdated
Show resolved
Hide resolved
kaiarrowood
changed the title
aanchalm01
reviewed
Aug 13, 2024
There was a problem hiding this comment.
Code looks good.
However, id field is missing in the Terraform format for any entity.
Eg:
I am not familiar with Terraform, but
- why is it my_** for every resource ? eg: resource "konnect_gateway_service" "my_service" {
- same with my_** in control_plane_id = konnect_gateway_control_plane.my_konnect_cp.id
packages/entities/entities-upstreams-targets/src/components/TargetForm.vue
Outdated
Show resolved
Hide resolved
mptap
reviewed
Aug 13, 2024
mptap
reviewed
Aug 13, 2024
mptap
reviewed
Aug 13, 2024
| CaCertificate = 'ca_certificate', | ||
| Certificate = 'certificate', | ||
| Consumer = 'consumer', | ||
| ConsumerGroup = 'consumer_group', |
There was a problem hiding this comment.
@kaiarrowood We need an entry for ConsumerCredential to display Terraform since we do display JSON/YAML Configuration in the ConsumerCredentialForm
Suggested change
| ConsumerGroup = 'consumer_group', | |
| ConsumerGroup = 'consumer_group', | |
| ConsumerCredential = 'consumer_credential', |
There was a problem hiding this comment.
Consumer credentials are plugins 🤔 I need to look into this
There was a problem hiding this comment.
Will fix in a future update
mptap
reviewed
Aug 13, 2024
There was a problem hiding this comment.
@kaiarrowood We need to display Terraform in the ConsumerCredentialForm since we do display JSON/YAML Configuration
packages/entities/entities-certificates/src/components/CACertificateConfigCard.vue
Show resolved
Hide resolved
Co-authored-by: Manjiri Tapaswi <[email protected]>
aanchalm01
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support to view terraform configuration for entities.
For KHCP-12445.
This work is behind a FF:
khcp-12445-terraform-config-detailsAdoption PR: https://github.com/Kong/konnect-ui-apps/pull/3935
Resources