Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(entities): max width of tooltips in entity forms #1591

Merged
merged 1 commit into from
Sep 5, 2024
Merged

fix(entities): max width of tooltips in entity forms #1591

merged 1 commit into from
Sep 5, 2024

Conversation

Leopoldthecoder
Copy link
Member

@Leopoldthecoder Leopoldthecoder commented Sep 5, 2024 •
edited
Loading

Summary

  • Add maxWidth to all label tooltips
  • Unify the max width to 400px
Before After
image image

KM-467

Resources

@Leopoldthecoder Leopoldthecoder marked this pull request as ready for review September 5, 2024 09:52
@Leopoldthecoder Leopoldthecoder requested review from a team as code owners September 5, 2024 09:52
@Leopoldthecoder Leopoldthecoder enabled auto-merge (squash) September 5, 2024 09:53
nekolab
nekolab approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@nekolab nekolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Leopoldthecoder Leopoldthecoder merged commit c34791c into main Sep 5, 2024
17 checks passed
@Leopoldthecoder Leopoldthecoder deleted the fix/form-tooltip-width branch September 5, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekolab nekolab nekolab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leopoldthecoder @nekolab