Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(forms): emit event for nested objects #1634

Merged
merged 2 commits into from
Sep 19, 2024
Merged

fix(forms): emit event for nested objects #1634

merged 2 commits into from
Sep 19, 2024

Conversation

Leopoldthecoder
Copy link
Member

Summary

KM-514

Resources

@Leopoldthecoder Leopoldthecoder marked this pull request as ready for review September 19, 2024 05:44
@Leopoldthecoder Leopoldthecoder enabled auto-merge (squash) September 19, 2024 07:56
sumimakito
sumimakito approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@sumimakito sumimakito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested and LGTM

@Leopoldthecoder Leopoldthecoder merged commit 35265c9 into main Sep 19, 2024
12 checks passed
@Leopoldthecoder Leopoldthecoder deleted the fix/nested-null-input branch September 19, 2024 09:13
@Leopoldthecoder Leopoldthecoder mentioned this pull request Sep 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Justineo Justineo Justineo left review comments

@sumimakito sumimakito sumimakito approved these changes

@LukeSwierlik LukeSwierlik Awaiting requested review from LukeSwierlik LukeSwierlik is a code owner

@QueaT-kong QueaT-kong Awaiting requested review from QueaT-kong QueaT-kong is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Leopoldthecoder @Justineo @sumimakito