fix(service): interpreting 0 as a boolean true

[Leopoldthecoder]

Summary

This PR fixes a bug where zero values are interpreted as true.

Before:

// when data.read_timeout is 0, the following evaluates to true
(data?.read_timeout || data?.read_timeout === 0) ?? 60000

After:

// when data.read_timeout is 0, the following evaluates to 0
(data?.read_timeout || data?.read_timeout === 0) ? data?.read_timeout : 60000

Fixes FTI-5437

PR Checklist

• Naming & Structure: the files and package structure use the conventions outlined in the Creating a Package docs.
• Tests pass: check the output of all package unit and/or component tests.
  • If this PR is the result of a bug, test coverage was added accordingly.
• Functional: all changes do not break existing APIs, but if so, a BREAKING CHANGE commit is in place to bump the major version.
• Conventional Commits all commits follow the conventional commit standards outlined in the main README.
• Docs: includes a technically accurate README, and the docs have been updated accordingly based on the changes in this PR.

[kaiarrowood]

LGTM! 🚀

Very interesting, I had to read up on nullish operator again to understand how we were getting true from this. It looks like a valid solution would also have been to just remove the === 0, but this works too.

[Leopoldthecoder]

Ah yes, data?.read_timeout ?? 60000 should be enough.