Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About time parameters: Physics vs Discretization [Inconsistent] #911

Open
miguelmaso opened this issue Nov 30, 2022 · 0 comments
Open

About time parameters: Physics vs Discretization [Inconsistent] #911

miguelmaso opened this issue Nov 30, 2022 · 0 comments

Comments

@miguelmaso
Copy link
Contributor

The following image corresponds to fluid problemtype, but its structure is commonly used in most problemtypes. In red, the physical nature of the problem is defined. In blue, discretization and numerical parameters are specified.

image

However, time settings are not following the stated convention. Total interval is a physical parameter, but it's not possible to modify it. Instead of this, there are a Start and End times (physical) under Solution parameters (discretization), mixed together with Delta time (dicrete).

Looking at the Kratos implementation, thing are managed more consistently: Start and End time are owned by the AnalysisStage (physical problem) while DeltaTime is owned by the Solver (discrete problem).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant