Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[I/O] Model part names inconsistencies in ProjectParameters.json #12199

Open
rubenzorrilla opened this issue Mar 18, 2024 · 2 comments
Open

[I/O] Model part names inconsistencies in ProjectParameters.json #12199

rubenzorrilla opened this issue Mar 18, 2024 · 2 comments
Assignees

Comments

@rubenzorrilla
Copy link
Member

Description
Right now, our ProjecParameters.json mixes both full model part names (e.g. in the processes) with partial ones (e.g. in the solver_settings). This a legacy inconsistency coming from the times in which we didn't have the Model container.

The @KratosMultiphysics/technical-committee is of the opinion of unifying everything to use full names, of course taking into account backward compatibility. Nevertheless, we would like to hear the community's opinion on this regard.

@loumalouomega
Copy link
Member

41483fa1b8949419ab5143f8981872bd
I hope we don't break up many things...

@RiccardoRossi
Copy link
Member

@KratosMultiphysics/technical-committee decided to go forward with this change. The practical implication is that old cases will need to be slightly updated to add the full path in the ProjectParameters.json

This implies that the warnings that are currently issued should be transformed into errors. Whenever possible solvers should be modified to give suggestions to the users on how to modify the input, nevertheless please note that there is no way this can be enforced outside of the main applications

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏗 In progress
Development

No branches or pull requests

3 participants