Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Noticeable lag when importing with ProgressLogging.jl #316

Closed
mkschleg opened this issue Mar 28, 2023 · 2 comments · May be fixed by #321
Closed

Noticeable lag when importing with ProgressLogging.jl #316

mkschleg opened this issue Mar 28, 2023 · 2 comments · May be fixed by #321

Comments

@mkschleg
Copy link

I'm noticing that there is considerable lag in the REPL when importing OhMyREPL.jl and ProgressLogging.jl on julia 1.9-rc1. The lag isn't in import, but the REPL hangs quite a bit after the second package is loaded (it doesn't matter which order).

Using:

ProgressLogging v0.1.4
OhMyREPL v0.5.20
@jakobnissen
Copy link
Contributor

jakobnissen commented Apr 4, 2023 •
edited
Loading

I see 136 invalidations in JuliaSyntax when loading ProgressLogging and 493 invalidations total, compared to 356 invalidations total when not loading OhMyREPL. I also experience this myself when loading JSON3. Unfortunately, timholy/SnoopCompile.jl#354 prevents me from finding the source.

The invalidations don't seem to happen from loading just JuliaSyntax, only in conjunction with OhMyREPL.

@jakobnissen jakobnissen mentioned this issue Apr 27, 2023
Open
@c42f c42f mentioned this issue Apr 27, 2023
Open
@mkschleg
Copy link
Author

Seems to be fixed in RC2. So I'm closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run OhMyREPL keybindings in a fixed world age c42f/OhMyREPL.jl
2 participants
@mkschleg @jakobnissen