Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syntext highlighting in 1.11 #342

Open
KronosTheLate opened this issue Mar 5, 2024 · 2 comments
Open

syntext highlighting in 1.11 #342

KronosTheLate opened this issue Mar 5, 2024 · 2 comments

Comments

@KronosTheLate
Copy link

The new julia stdlib JuliaSyntaxHighlighting will be introduced in 1.11:

A new standard library for applying syntax highlighting to Julia code, this uses JuliaSyntax and StyledStrings to implement a highlight function that creates an AnnotatedString with syntax highlighting applied.

Is this expected to collide with OhMyREPL in any way? Or perhaps it is the first step to integrate OhMyREPL functionality into base? In any case, a comment on the syntax highlighting introduced in 1.11 would be nice in the readme.

@KristofferC
Copy link
Owner

Is this expected to collide with OhMyREPL in any way?

Not until it is enabled in the REPL. Once it is and it works as well or better as what we have in OMR, we remove the highlight functionality from this package. We could also look into using that package for the syntax highlighting in OMR but the fact that all "passes" (like bracket highlight etc) builds open the same tokenizer make things quite nice and composable.

@KronosTheLate
Copy link
Author

Great, so it seems like you have though of it over here. Feel free to close this, or keep it around until this has in fact been dealt with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants