Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update warmstart #1790

Closed
wrashid opened this issue May 7, 2019 · 3 comments
Closed

update warmstart #1790

wrashid opened this issue May 7, 2019 · 3 comments
Assignees

Comments

@wrashid
Copy link
Collaborator

wrashid commented May 7, 2019

-> e.g. include sampled vehicles, including personal CAVs
-> what else needs to be loaded?

@JustinPihony
Copy link
Collaborator

@wrashid After talking to Colin and Carlos I believe this work is a bit duplicative to the work being done for reading and writing csv. i.e. - #1839

That said, it was discussed that given the new procedural, on the fly nature, we should clean the code such that it follows clear stages:

  • Read any data available (this includes warmstart and root files such as vehicles or households)
  • Fill in the rest of the data
  • Write out the final data to the output directory (for later reading back in maybe)
  • Execute the simulation

If that resonates with you then I'm proposing that we complete the above mentioned PR and create a new issue for the above reorganization. Along with that, create two new issues to migrate ridehailfleet data and urbansim data such that they are output to the root, rather than per iteration - as they are redundant beyond the initial load. Of course those additional two items need verified, but Colin seemed confident that they should be movable to root.

@wrashid
Copy link
Collaborator Author

wrashid commented May 21, 2019

@JustinPihony yes, the idea is that we would use the readers provided by @carloscaldas for this task. Plan makes sense. Please coordinate with @carloscaldas and let us discuss if any open questions.

@JustinPihony
Copy link
Collaborator

Closing this issue in favor of the work @carloscaldas has already done and what is to be done via #1853

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants