smart-baseline. A lot of errors "Current tour vehicle is the same as the one being removed"

[REASY]

One of the latest runs on production-sfbay-develop produces a lot of errors like the following:

17:54:08.212 [ClusterSystem-akka.actor.default-dispatcher-110] ERROR beam.agentsim.agents.PersonAgent - State:FinishingModeChoice PersonAgent:1417264  Current tour vehicle is the same as the one being removed: 3573631 - 3573631 - ChoosesModeData(BasePersonData(1,None,List(),Vector(),Some(DRIVE_TRANSIT),Some(3573631),BeamLeg(WALK @ 32790,dur:198,path: 175256 .. 85767) -> [0riders;0boarders;0alighters],1,false,0.0,0,None),SpaceTime([x=579656.3220734914][y=4142147.7608571793],57893),Some(EmbodiedBeamTrip(WALK starts 57893 legModes WALK)),Some(RoutingResponse(ArrayBuffer(EmbodiedBeamTrip(CAR starts 57893 legModes WALK,CAR,CAR,WALK)),2220974,Some(RoutingRequest([x=579656.3220734914][y=4142147.7608571793],[x=575273.6173475499][y=4142524.621418717],57893,true,Vector(StreetVehicle(3573631,conv-L1-50000-to-75000-LowTech-2019,SpaceTime([x=579580.3600512043][y=4143109.4244455737],32694),CAR,true), StreetVehicle(body-1417264,BODY-TYPE-DEFAULT,SpaceTime([x=579656.3220734914][y=4142147.7608571793],57893),WALK,true)),Some(AttributesOfIndividual(HouseholdAttributes(511943,75000.0,1,0,1),None,false,List(CAR, CAV, WALK, BIKE, TRANSIT, RIDE_HAIL, RIDE_HAIL_POOLED, RIDE_HAIL_TRANSIT, DRIVE_TRANSIT, WALK_TRANSIT),18.38235294117647,Some(0),Some(0.0))),Egress,2220974)),false)),Some(ParkingInquiryResponse(ParkingStall(351,6462,[x=575269.8076707143][y=4142498.732458547],0.0,None,Some(Block),Residential),1592379)),Some(1592379),Some(ParkingInquiryResponse(ParkingStall(emergency,-1,[x=618242.6729344203][y=4202717.207406929],0.0,None,Some(FlatFee),Public),0)),None,Some(RideHailResponse(request: RideHailRequest(id: 0, type: RideHailInquiry, customer: dummy, pickup: [x=NaN][y=NaN], time: 2147483647, dest: [x=NaN][y=NaN]), error: Some(RideHailNotRequestedError), travelProposal: None)),Some(EmbodiedBeamTrip(WALK starts empty legModes )),None,Some(RideHailResponse(request: RideHailRequest(id: 0, type: RideHailInquiry, customer: dummy, pickup: [x=NaN][y=NaN], time: 2147483647, dest: [x=NaN][y=NaN]), error: Some(RideHailNotRequestedError), travelProposal: None)),None,Some(RideHailResponse(request: RideHailRequest(id: 0, type: RideHailInquiry, customer: dummy, pickup: [x=NaN][y=NaN], time: 2147483647, dest: [x=NaN][y=NaN]), error: Some(RideHailNotRequestedError), travelProposal: None)),None,Vector(ActualVehicle(3573631 (conv-L1-50000-to-75000-LowTech-2019))),None,false,Some(CavTripLegsResponse(None,List())),Vector(),Some())
17:54:08.267 [ClusterSystem-akka.actor.default-dispatcher-76] ERROR beam.agentsim.agents.PersonAgent - State:FinishingModeChoice PersonAgent:6769706  Current tour vehicle is the same as the one being removed: 4096023 - 4096023 - ChoosesModeData(BasePersonData(1,Some(EmbodiedBeamTrip(DRIVE_TRANSIT starts 57566 legModes WALK,BUS,WALK,BUS,WALK,CAR,CAR,WALK)),List(EmbodiedBeamLeg(BeamLeg(BUS @ 57900,dur:3960,path: ),GG:5186109-16MARCH-01-WKDY-Weekday-04,null,false,0.0,false,false,0.0), EmbodiedBeamLeg(BeamLeg(WALK @ 61860,dur:34,path: 133558 .. 133563),body-6769706,BODY-TYPE-DEFAULT,true,0.0,false,false,0.0), EmbodiedBeamLeg(BeamLeg(BUS @ 62250,dur:30,path: ),GG:5192663-16MARCH-01-WKDY-Weekday-05,null,false,0.0,false,false,0.0), EmbodiedBeamLeg(BeamLeg(WALK @ 62280,dur:0,path: 134202 .. 134202),body-6769706,BODY-TYPE-DEFAULT,true,0.0,true,false,0.0), EmbodiedBeamLeg(BeamLeg(CAR @ 62280,dur:632,path: 134201 .. 51256),4096023,conv-L1-75000-to-100000-LowTech-2019,true,1.9852851028788,false,false,0.0), EmbodiedBeamLeg(BeamLeg(CAR @ 62912,dur:21,path: 51256 .. 51255),4096023,conv-L1-75000-to-100000-LowTech-2019,true,0.0,true,false,0.0), EmbodiedBeamLeg(BeamLeg(WALK @ 62933,dur:0,path: ),body-6769706,BODY-TYPE-DEFAULT,true,0.0,true,false,0.0)),Vector(body-6769706),Some(DRIVE_TRANSIT),Some(4096023),BeamLeg(WALK @ 57566,dur:299,path: 143057 .. 134689) -> [0riders;0boarders;0alighters],1,true,0.0,1,None),SpaceTime([x=553072.907163597][y=4182787.833585666],57865),Some(EmbodiedBeamTrip(WALK starts 57865 legModes WALK)),Some(RoutingResponse(ArrayBuffer(EmbodiedBeamTrip(DRIVE_TRANSIT starts 58137 legModes WALK,BUS,WALK,CAR,CAR,WALK)),2220357,Some(RoutingRequest([x=553072.907163597][y=4182787.833585666],[x=533330.57280717][y=4234093.776312554],57865,true,Vector(StreetVehicle(4096023,conv-L1-75000-to-100000-LowTech-2019,SpaceTime([x=536889.7742969928][y=4219300.587127951],20374),CAR,true), StreetVehicle(body-6769706,BODY-TYPE-DEFAULT,SpaceTime([x=553072.907163597][y=4182787.833585666],57865),WALK,true)),Some(AttributesOfIndividual(HouseholdAttributes(2513375,92000.0,1,0,1),None,false,List(CAR, CAV, WALK, BIKE, TRANSIT, RIDE_HAIL, RIDE_HAIL_POOLED, RIDE_HAIL_TRANSIT, DRIVE_TRANSIT, WALK_TRANSIT),22.54901960784314,Some(0),Some(0.0))),Egress,2220357)),false)),Some(ParkingInquiryResponse(ParkingStall(1336,25296,[x=533341.4090767532][y=4234467.82523122],0.0,None,Some(Block),Public),1591810)),Some(1591810),Some(ParkingInquiryResponse(ParkingStall(emergency,-1,[x=637264.358697888][y=4119473.6581159625],0.0,None,Some(FlatFee),Public),0)),None,Some(RideHailResponse(request: RideHailRequest(id: 0, type: RideHailInquiry, customer: dummy, pickup: [x=NaN][y=NaN], time: 2147483647, dest: [x=NaN][y=NaN]), error: Some(RideHailNotRequestedError), travelProposal: None)),Some(EmbodiedBeamTrip(WALK starts empty legModes )),None,Some(RideHailResponse(request: RideHailRequest(id: 0, type: RideHailInquiry, customer: dummy, pickup: [x=NaN][y=NaN], time: 2147483647, dest: [x=NaN][y=NaN]), error: Some(RideHailNotRequestedError), travelProposal: None)),None,Some(RideHailResponse(request: RideHailRequest(id: 0, type: RideHailInquiry, customer: dummy, pickup: [x=NaN][y=NaN], time: 2147483647, dest: [x=NaN][y=NaN]), error: Some(RideHailNotRequestedError), travelProposal: None)),None,Vector(ActualVehicle(4096023 (conv-L1-75000-to-100000-LowTech-2019))),None,true,Some(CavTripLegsResponse(None,List())),Vector(),Some())
17:54:08.508 [ClusterSystem-akka.actor.default-dispatcher-68] ERROR beam.agentsim.agents.PersonAgent - State:FinishingModeChoice PersonAgent:2833840  Current tour vehicle is the same as the one being removed: 124522 - 124522 - ChoosesModeData(BasePersonData(1,None,List(),Vector(),Some(DRIVE_TRANSIT),Some(124522),BeamLeg(WALK @ 30876,dur:842,path: 103250 .. 78995) -> [0riders;0boarders;0alighters],1,false,0.0,0,None),SpaceTime([x=566925.7698996745][y=4175698.925790861],57909),Some(EmbodiedBeamTrip(WALK starts 57909 legModes WALK)),Some(RoutingResponse(ArrayBuffer(EmbodiedBeamTrip(CAR starts 57909 legModes WALK,CAR,CAR,WALK)),2221407,Some(RoutingRequest([x=566925.7698996745][y=4175698.925790861],[x=574615.8753494954][y=4175865.799901433],57909,true,Vector(StreetVehicle(124522,conv-L1-25000-to-50000-LowTech-2019,SpaceTime([x=567885.0959111621][y=4176063.2169133266],30306),CAR,true), StreetVehicle(body-2833840,BODY-TYPE-DEFAULT,SpaceTime([x=566925.7698996745][y=4175698.925790861],57909),WALK,true)),Some(AttributesOfIndividual(HouseholdAttributes(1057879,32400.0,2,0,1),None,true,List(CAR, CAV, WALK, BIKE, TRANSIT, RIDE_HAIL, RIDE_HAIL_POOLED, RIDE_HAIL_TRANSIT, DRIVE_TRANSIT, WALK_TRANSIT),7.9411764705882355,Some(0),Some(0.0))),Egress,2221407)),false)),Some(ParkingInquiryResponse(ParkingStall(871,16582,[x=574648.048940201][y=4175931.667504319],0.0,None,Some(Block),Residential),1592745)),Some(1592745),Some(ParkingInquiryResponse(ParkingStall(emergency,-1,[x=521471.63062613795][y=4276765.59335523],0.0,None,Some(FlatFee),Public),0)),None,Some(RideHailResponse(request: RideHailRequest(id: 0, type: RideHailInquiry, customer: dummy, pickup: [x=NaN][y=NaN], time: 2147483647, dest: [x=NaN][y=NaN]), error: Some(RideHailNotRequestedError), travelProposal: None)),Some(EmbodiedBeamTrip(WALK starts empty legModes )),None,Some(RideHailResponse(request: RideHailRequest(id: 0, type: RideHailInquiry, customer: dummy, pickup: [x=NaN][y=NaN], time: 2147483647, dest: [x=NaN][y=NaN]), error: Some(RideHailNotRequestedError), travelProposal: None)),None,Some(RideHailResponse(request: RideHailRequest(id: 0, type: RideHailInquiry, customer: dummy, pickup: [x=NaN][y=NaN], time: 2147483647, dest: [x=NaN][y=NaN]), error: Some(RideHailNotRequestedError), travelProposal: None)),None,Vector(ActualVehicle(124522 (conv-L1-25000-to-50000-LowTech-2019))),None,false,Some(CavTripLegsResponse(None,List())),Vector(),Some())
17:54:08.530 [ClusterSystem-akka.actor.default-dispatcher-13] ERROR beam.agentsim.agents.PersonAgent - State:FinishingModeChoice PersonAgent:6772215  Current tour vehicle is the same as the one being removed: 4350951 - 4350951 - ChoosesModeData(BasePersonData(1,Some(EmbodiedBeamTrip(DRIVE_TRANSIT starts 57669 legModes WALK,BUS,WALK,BUS,WALK,CAR,CAR,WALK)),List(EmbodiedBeamLeg(BeamLeg(BUS @ 57900,dur:3960,path: ),GG:5186109-16MARCH-01-WKDY-Weekday-04,null,false,0.0,false,false,0.0), EmbodiedBeamLeg(BeamLeg(WALK @ 61860,dur:34,path: 133558 .. 133563),body-6772215,BODY-TYPE-DEFAULT,true,0.0,false,false,0.0), EmbodiedBeamLeg(BeamLeg(BUS @ 62250,dur:30,path: ),GG:5192663-16MARCH-01-WKDY-Weekday-05,null,false,0.0,false,false,0.0), EmbodiedBeamLeg(BeamLeg(WALK @ 62280,dur:0,path: 134202 .. 134202),body-6772215,BODY-TYPE-DEFAULT,true,0.0,true,false,0.0), EmbodiedBeamLeg(BeamLeg(CAR @ 62280,dur:649,path: 134201 .. 92040),4350951,conv-L1-25000-to-50000-LowTech-2019,true,2.116998326583001,false,false,0.0), EmbodiedBeamLeg(BeamLeg(CAR @ 62929,dur:53,path: 92040 .. 136431),4350951,conv-L1-25000-to-50000-LowTech-2019,true,0.0,true,false,0.0), EmbodiedBeamLeg(BeamLeg(WALK @ 62982,dur:0,path: ),body-6772215,BODY-TYPE-DEFAULT,true,0.0,true,false,0.0)),Vector(body-6772215),Some(DRIVE_TRANSIT),Some(4350951),BeamLeg(WALK @ 57669,dur:231,path: 20958 .. 134689) -> [0riders;0boarders;0alighters],1,true,0.0,1,None),SpaceTime([x=553072.907163597][y=4182787.833585666],57900),Some(EmbodiedBeamTrip(WALK starts 57900 legModes WALK)),Some(RoutingResponse(ArrayBuffer(EmbodiedBeamTrip(DRIVE_TRANSIT starts 58137 legModes WALK,BUS,WALK,CAR,CAR,WALK)),2221230,Some(RoutingRequest([x=553072.907163597][y=4182787.833585666],[x=530873.9835594122][y=4231368.895936522],57900,true,Vector(StreetVehicle(4350951,conv-L1-25000-to-50000-LowTech-2019,SpaceTime([x=536889.7742969928][y=4219300.587127951],27510),CAR,true), StreetVehicle(body-6772215,BODY-TYPE-DEFAULT,SpaceTime([x=553072.907163597][y=4182787.833585666],57900),WALK,true)),Some(AttributesOfIndividual(HouseholdAttributes(2526899,35000.0,2,0,1),None,true,List(CAR, CAV, WALK, BIKE, TRANSIT, RIDE_HAIL, RIDE_HAIL_POOLED, RIDE_HAIL_TRANSIT, DRIVE_TRANSIT, WALK_TRANSIT),8.57843137254902,Some(0),Some(0.0))),Egress,2221230)),false)),Some(ParkingInquiryResponse(ParkingStall(1329,25158,[x=530734.9886338053][y=4231318.817993872],0.0,None,Some(Block),Residential),1592576)),Some(1592576),Some(ParkingInquiryResponse(ParkingStall(emergency,-1,[x=556689.7592003148][y=4232504.999836167],0.0,None,Some(FlatFee),Public),0)),None,Some(RideHailResponse(request: RideHailRequest(id: 0, type: RideHailInquiry, customer: dummy, pickup: [x=NaN][y=NaN], time: 2147483647, dest: [x=NaN][y=NaN]), error: Some(RideHailNotRequestedError), travelProposal: None)),Some(EmbodiedBeamTrip(WALK starts empty legModes )),None,Some(RideHailResponse(request: RideHailRequest(id: 0, type: RideHailInquiry, customer: dummy, pickup: [x=NaN][y=NaN], time: 2147483647, dest: [x=NaN][y=NaN]), error: Some(RideHailNotRequestedError), travelProposal: None)),None,Some(RideHailResponse(request: RideHailRequest(id: 0, type: RideHailInquiry, customer: dummy, pickup: [x=NaN][y=NaN], time: 2147483647, dest: [x=NaN][y=NaN]), error: Some(RideHailNotRequestedError), travelProposal: None)),None,Vector(ActualVehicle(4350951 (conv-L1-25000-to-50000-LowTech-2019))),None,true,Some(CavTripLegsResponse(None,List())),Vector(),Some())

Is it critical?

[JustinPihony]

I added this to fix a bug. Maybe it should be changed to a warning...and/or we should also keep this issue open to dig into the why this is happening even deeper?