Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests on OSX sometimes fail because of a segmentation fault #723

Closed
haasad opened this issue Feb 18, 2022 · 2 comments · Fixed by #724
Closed

Tests on OSX sometimes fail because of a segmentation fault #723

haasad opened this issue Feb 18, 2022 · 2 comments · Fixed by #724

Comments

@haasad
Copy link
Member

haasad commented Feb 18, 2022

See discussions in #707 and #711, d6e29cc

Example of a workflow that fails: https://github.com/LCA-ActivityBrowser/activity-browser/runs/5232989949?check_suite_focus=true

@haasad
Copy link
Member Author

haasad commented Feb 18, 2022

#707 (comment)

@haasad this MacOs test failed twice, do I just keep re-running the test or is there a way to find if it is my code that is actually failing?

@marc-vdm I think it's highly unlikely that your changes cause the segmentation fault. My guess is that something with the tests itself causes the segfault. E.g. some python object that is garbage-collected too early which trips Qt and causes the segfault.

I'd argue that it's not worth to invest more time into this unless there's a report of a Mac AB users that experiences this segfault during real usage. We still test the functionality iteself on windows and linux. I'd just skip all the problematic tests, see my linked PR.

@marc-vdm
Copy link
Member

I've moved the review on #724 to bs, but I'm assuming it will get merged! Thanks again for helping to sort this out, this is greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants