Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

Make SpkTxOutIndex::add_spk handle duplicate spks under different indexes #98

Closed
LLFourn opened this issue Dec 20, 2022 · 1 comment · Fixed by #118
Closed

Make SpkTxOutIndex::add_spk handle duplicate spks under different indexes #98

LLFourn opened this issue Dec 20, 2022 · 1 comment · Fixed by #118

Comments

@LLFourn
Copy link
Owner

LLFourn commented Dec 20, 2022

What should we do here? The simplest thing would be to return a bool or result indicating whether we ignored the request or not because it is already under another index.
@LLFourn LLFourn mentioned this issue Dec 21, 2022
Closed
@rajarshimaitra
Copy link
Collaborator

I think the simplest is to just return false if it already exists..

@rajarshimaitra rajarshimaitra mentioned this issue Dec 28, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix add_spk API rajarshimaitra/bdk_core_staging
2 participants
@LLFourn @rajarshimaitra