{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":15778896,"defaultBranch":"master","name":"lmms","ownerLogin":"LMMS","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2014-01-09T20:43:43.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/6363159?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1722783689.0","currentOid":""},"activityList":{"items":[{"before":"c952d56591b82d51fe2464af73dc6696b25649f8","after":"1d7ed16dc93630ec12f55a992b71181b7e45a0a5","ref":"refs/heads/master","pushedAt":"2024-09-19T16:53:40.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"sakertooth","name":"saker","path":"/sakertooth","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20197645?s=80&v=4"},"commit":{"message":"Make the send button and receive arrow occupy the same space in mixer channels (#7503)","shortMessageHtmlLink":"Make the send button and receive arrow occupy the same space in mixer…"}},{"before":"01294192c8e39158e21e404bfec09139f78caaf3","after":"c952d56591b82d51fe2464af73dc6696b25649f8","ref":"refs/heads/master","pushedAt":"2024-09-19T16:00:17.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"sakertooth","name":"saker","path":"/sakertooth","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20197645?s=80&v=4"},"commit":{"message":"Restore some whitespace to the mixer channel layout (#7507)","shortMessageHtmlLink":"Restore some whitespace to the mixer channel layout (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2534212692\" data-permission-text=\"Title is private\" data-url=\"https://github.com/LMMS/lmms/issues/7507\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/LMMS/lmms/pull/7507/hovercard\" href=\"https://github.com/LMMS/lmms/pull/7507\">#7507</a>)"}},{"before":"4803bbb73ad3e7b9e36c39cabdec3aff6f1dafe4","after":"01294192c8e39158e21e404bfec09139f78caaf3","ref":"refs/heads/master","pushedAt":"2024-09-18T15:25:47.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"sakertooth","name":"saker","path":"/sakertooth","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20197645?s=80&v=4"},"commit":{"message":"Fix Lb302 silence (#7504)\n\nThis problem seem to arise due to casting _n->framesLeft() and _n->offset() from an unsigned type (size_t) to a signed type (int). The fix is to use size_t as the type for std::max across the board.","shortMessageHtmlLink":"Fix Lb302 silence (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2533738605\" data-permission-text=\"Title is private\" data-url=\"https://github.com/LMMS/lmms/issues/7504\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/LMMS/lmms/pull/7504/hovercard\" href=\"https://github.com/LMMS/lmms/pull/7504\">#7504</a>)"}},{"before":"7d35d4225ecfdddc9eedc3060bb8ee1e24833768","after":"4803bbb73ad3e7b9e36c39cabdec3aff6f1dafe4","ref":"refs/heads/master","pushedAt":"2024-09-18T08:45:46.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"sakertooth","name":"saker","path":"/sakertooth","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20197645?s=80&v=4"},"commit":{"message":"Shrink mixer channel strip (#7502)\n\nRemove all content margins and spacing between child widgets for each mixer channel strip.","shortMessageHtmlLink":"Shrink mixer channel strip (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2531828825\" data-permission-text=\"Title is private\" data-url=\"https://github.com/LMMS/lmms/issues/7502\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/LMMS/lmms/pull/7502/hovercard\" href=\"https://github.com/LMMS/lmms/pull/7502\">#7502</a>)"}},{"before":"588aab338968864ae250709f3312fcd9bb481430","after":"7d35d4225ecfdddc9eedc3060bb8ee1e24833768","ref":"refs/heads/master","pushedAt":"2024-09-17T06:05:01.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Rossmaxx","name":"Rossmaxx","path":"/Rossmaxx","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/74815851?s=80&v=4"},"commit":{"message":"SlicerT UI update (#7453)\n\n* Update SlicerT UI\r\n\r\n* Style review\r\n\r\nCo-authored-by: Rossmaxx <74815851+Rossmaxx@users.noreply.github.com>\r\n\r\n* Style fixes\r\n\r\n---------\r\n\r\nCo-authored-by: Rossmaxx <74815851+Rossmaxx@users.noreply.github.com>","shortMessageHtmlLink":"SlicerT UI update (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2466861081\" data-permission-text=\"Title is private\" data-url=\"https://github.com/LMMS/lmms/issues/7453\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/LMMS/lmms/pull/7453/hovercard\" href=\"https://github.com/LMMS/lmms/pull/7453\">#7453</a>)"}},{"before":"e139c206118fb5de7b7f60385a337b41be9e7c2e","after":"16b9c2d7aafd3f30c50e6d856538311feb4d91b6","ref":"refs/heads/qt6","pushedAt":"2024-09-16T12:14:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"PhysSong","name":"Hyunjin Song","path":"/PhysSong","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12591074?s=80&v=4"},"commit":{"message":"Fix MSVC builds","shortMessageHtmlLink":"Fix MSVC builds"}},{"before":"d76027cf8153da55b5373bb64c4f8024d30cd6e1","after":"e139c206118fb5de7b7f60385a337b41be9e7c2e","ref":"refs/heads/qt6","pushedAt":"2024-09-16T02:45:52.000Z","pushType":"push","commitsCount":55,"pusher":{"login":"PhysSong","name":"Hyunjin Song","path":"/PhysSong","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12591074?s=80&v=4"},"commit":{"message":"Fix compilation","shortMessageHtmlLink":"Fix compilation"}},{"before":"48314959b8ad83a316fa6b8cafdcda009238efa7","after":"588aab338968864ae250709f3312fcd9bb481430","ref":"refs/heads/master","pushedAt":"2024-09-15T16:10:05.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Rossmaxx","name":"Rossmaxx","path":"/Rossmaxx","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/74815851?s=80&v=4"},"commit":{"message":"Replace Compressor infinite ratio icons (#7501)","shortMessageHtmlLink":"Replace Compressor infinite ratio icons (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2526977878\" data-permission-text=\"Title is private\" data-url=\"https://github.com/LMMS/lmms/issues/7501\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/LMMS/lmms/pull/7501/hovercard\" href=\"https://github.com/LMMS/lmms/pull/7501\">#7501</a>)"}},{"before":"d703f391533c3c5c682b5baf0984be44b8786bfa","after":"48314959b8ad83a316fa6b8cafdcda009238efa7","ref":"refs/heads/master","pushedAt":"2024-09-13T22:54:00.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"sakertooth","name":"saker","path":"/sakertooth","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20197645?s=80&v=4"},"commit":{"message":"Fix sample clip position when reversing (#7446)","shortMessageHtmlLink":"Fix sample clip position when reversing (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2459732186\" data-permission-text=\"Title is private\" data-url=\"https://github.com/LMMS/lmms/issues/7446\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/LMMS/lmms/pull/7446/hovercard\" href=\"https://github.com/LMMS/lmms/pull/7446\">#7446</a>)"}},{"before":"b81f806d637865922eb4abcf04275ff782e947d8","after":"d703f391533c3c5c682b5baf0984be44b8786bfa","ref":"refs/heads/master","pushedAt":"2024-09-04T16:58:36.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"sakertooth","name":"saker","path":"/sakertooth","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20197645?s=80&v=4"},"commit":{"message":"Process metronome every MIDI tick (#7483)","shortMessageHtmlLink":"Process metronome every MIDI tick (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2499374080\" data-permission-text=\"Title is private\" data-url=\"https://github.com/LMMS/lmms/issues/7483\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/LMMS/lmms/pull/7483/hovercard\" href=\"https://github.com/LMMS/lmms/pull/7483\">#7483</a>)"}},{"before":"9a76d31732819268c99f0136bd70c0f2d59f4ca1","after":"b81f806d637865922eb4abcf04275ff782e947d8","ref":"refs/heads/master","pushedAt":"2024-09-03T12:30:28.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Rossmaxx","name":"Rossmaxx","path":"/Rossmaxx","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/74815851?s=80&v=4"},"commit":{"message":"Fix: unnecessary space in Update EqControlsDialog.cpp (#7485)\n\n* Fix: unnecessary space in Update EqControlsDialog.cpp\r\n\r\nFix: unnecessary space in Update EqControlsDialog.cpp\r\n\r\nGreetings,\r\nGootector\r\n\r\n* Style fix from Ross\r\n\r\n---------\r\n\r\nCo-authored-by: Rossmaxx <74815851+Rossmaxx@users.noreply.github.com>","shortMessageHtmlLink":"Fix: unnecessary space in Update EqControlsDialog.cpp (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2502725605\" data-permission-text=\"Title is private\" data-url=\"https://github.com/LMMS/lmms/issues/7485\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/LMMS/lmms/pull/7485/hovercard\" href=\"https://github.com/LMMS/lmms/pull/7485\">#7485</a>)"}},{"before":"35f350eeffdeb3f0f280ad03b95520421d80c593","after":"9a76d31732819268c99f0136bd70c0f2d59f4ca1","ref":"refs/heads/master","pushedAt":"2024-09-02T14:44:44.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"sakertooth","name":"saker","path":"/sakertooth","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20197645?s=80&v=4"},"commit":{"message":"Fix typo in DataFile.cpp (#7478)","shortMessageHtmlLink":"Fix typo in DataFile.cpp (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2498890232\" data-permission-text=\"Title is private\" data-url=\"https://github.com/LMMS/lmms/issues/7478\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/LMMS/lmms/pull/7478/hovercard\" href=\"https://github.com/LMMS/lmms/pull/7478\">#7478</a>)"}},{"before":"a992019626ef15b9bf34174de285b4a5c986bb08","after":"35f350eeffdeb3f0f280ad03b95520421d80c593","ref":"refs/heads/master","pushedAt":"2024-08-28T19:46:48.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"messmerd","name":"Dalton Messmer","path":"/messmerd","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/33463986?s=80&v=4"},"commit":{"message":"Remove Noise class from flanger (#7473)","shortMessageHtmlLink":"Remove Noise class from flanger (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2491638096\" data-permission-text=\"Title is private\" data-url=\"https://github.com/LMMS/lmms/issues/7473\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/LMMS/lmms/pull/7473/hovercard\" href=\"https://github.com/LMMS/lmms/pull/7473\">#7473</a>)"}},{"before":"ff8c47062f4480a6252b09cd4b1075780d5e5678","after":"a992019626ef15b9bf34174de285b4a5c986bb08","ref":"refs/heads/master","pushedAt":"2024-08-28T07:18:56.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Rossmaxx","name":"Rossmaxx","path":"/Rossmaxx","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/74815851?s=80&v=4"},"commit":{"message":"Cleanup `lmms_math.h` (#7382)\n\n* simplified fraction and absfraction functions\r\n\r\n* removed unused fastSqrt() and fastPow()  \r\nfunctions\r\n\r\n* unused absMin() and absMax()\r\n\r\n* move roundAt to math header\r\n\r\n* Code review from saker\r\n\r\nCo-authored-by: saker <sakertooth@gmail.com>\r\n\r\n* use std::trunc()\r\n\r\n* fixup after fixing merge conflicts\r\n\r\n* remove unused fastFma and fastFmal functions.\r\n\r\n* remove lmms_basics include, not needed\r\n\r\n* use signedPowf from lmms_math in NES\r\n\r\n* removed fastRand function, unused\r\n\r\n* remove unused sinc function\r\n\r\n* cleanup signedPowf\r\n\r\n* code review\r\n\r\n* further simplify random number math\r\n\r\n* removed static from lmms_math file\r\n\r\n---------\r\n\r\nCo-authored-by: saker <sakertooth@gmail.com>","shortMessageHtmlLink":"Cleanup <code>lmms_math.h</code> (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2410368215\" data-permission-text=\"Title is private\" data-url=\"https://github.com/LMMS/lmms/issues/7382\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/LMMS/lmms/pull/7382/hovercard\" href=\"https://github.com/LMMS/lmms/pull/7382\">#7382</a>)"}},{"before":"88ee83bb4aebdb4ce3ed27195288453e22dc715a","after":"ff8c47062f4480a6252b09cd4b1075780d5e5678","ref":"refs/heads/master","pushedAt":"2024-08-20T18:32:47.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"sakertooth","name":"saker","path":"/sakertooth","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20197645?s=80&v=4"},"commit":{"message":"Continue processing `Song` even when no tracks are found (#7458)","shortMessageHtmlLink":"Continue processing <code>Song</code> even when no tracks are found (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2471557533\" data-permission-text=\"Title is private\" data-url=\"https://github.com/LMMS/lmms/issues/7458\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/LMMS/lmms/pull/7458/hovercard\" href=\"https://github.com/LMMS/lmms/pull/7458\">#7458</a>)"}},{"before":"5e697f01c8570dbaf649d15971be606b16de1f58","after":"88ee83bb4aebdb4ce3ed27195288453e22dc715a","ref":"refs/heads/master","pushedAt":"2024-08-20T17:50:39.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"michaelgregorius","name":"Michael Gregorius","path":"/michaelgregorius","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9293269?s=80&v=4"},"commit":{"message":"Do not save MIDI connections in presets (#7445)\n\nEnsure that no MIDI information (connected inputs, outputs, etc.) is\r\nstored in presets. This main fix can be found in\r\n`InstrumentTrack::saveTrackSpecificSettings` where the state of the\r\nMIDI ports are now only saved if we are not in preset mode.\r\n\r\nThe remaining changes are concered with a refactoring of the code\r\nthat's related to saving and loading presets.\r\n\r\nThe refactoring mainly revolves around the removal of the member\r\n`m_simpleSerializingMode` and the method `setSimpleSerializing` in\r\n`Track`.\r\n\r\nThis is accomplished by introducing two new methods `saveTrack` and\r\n`loadTrack`. These methods have a similar interface to `saveSettings`\r\nand `loadSettings` but they additionally contain a boolean which\r\nindicates if a preset is saved/loaded or a whole track. Both new\r\nmethods contain the previous code of `saveSettings` and `loadSettings`.\r\nThe latter two now only delegate to the new methods assuming that the\r\nfull track is to be stored/loaded if called via the overridden methods\r\n`saveSettings` and `loadSettings`.\r\n\r\nThe methods `savePreset` and `loadPreset` are added as well. They call\r\n`saveTrack` and `loadTrack` with the preset boolean set to `true`.\r\nThese methods are now used by all places in the code where presets are\r\nsaved or loaded which makes the code more readable. Clients also do not\r\nneed to know any implementation details of `Track`, e.g. like having to\r\ncall `setSimpleSerializing`.\r\n\r\nAdjust `saveTrackSpecificSettings` so that it also passes information\r\nof whether a preset or a whole track is stored. This leads to changes\r\nin the interfaces of `AutomationTrack`, `InstrumentTrack`,\r\n`PatternTrack` and `SampleTrack`. Only the implementation of\r\n`InstrumentTrack` uses the new information though.","shortMessageHtmlLink":"Do not save MIDI connections in presets (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2459497847\" data-permission-text=\"Title is private\" data-url=\"https://github.com/LMMS/lmms/issues/7445\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/LMMS/lmms/pull/7445/hovercard\" href=\"https://github.com/LMMS/lmms/pull/7445\">#7445</a>)"}},{"before":"58ce9b476af8ddbef004b1665eadf1ecdcfba00b","after":"5e697f01c8570dbaf649d15971be606b16de1f58","ref":"refs/heads/master","pushedAt":"2024-08-19T17:20:19.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"sakertooth","name":"saker","path":"/sakertooth","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20197645?s=80&v=4"},"commit":{"message":"Fix zooming and sliding of the waveform view in AudioFileProcessor (#7377)","shortMessageHtmlLink":"Fix zooming and sliding of the waveform view in AudioFileProcessor (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2405226232\" data-permission-text=\"Title is private\" data-url=\"https://github.com/LMMS/lmms/issues/7377\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/LMMS/lmms/pull/7377/hovercard\" href=\"https://github.com/LMMS/lmms/pull/7377\">#…</a>"}},{"before":"bda1a9c37ed29cd7c80f08d7405dd4dbfad8947d","after":"58ce9b476af8ddbef004b1665eadf1ecdcfba00b","ref":"refs/heads/master","pushedAt":"2024-08-16T16:50:39.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Rossmaxx","name":"Rossmaxx","path":"/Rossmaxx","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/74815851?s=80&v=4"},"commit":{"message":"Fix track handles dissapearing (#6338)","shortMessageHtmlLink":"Fix track handles dissapearing (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1176733983\" data-permission-text=\"Title is private\" data-url=\"https://github.com/LMMS/lmms/issues/6338\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/LMMS/lmms/pull/6338/hovercard\" href=\"https://github.com/LMMS/lmms/pull/6338\">#6338</a>)"}},{"before":"d8e4d8c115d2e7b34943d01223c574327cd1a173","after":"bda1a9c37ed29cd7c80f08d7405dd4dbfad8947d","ref":"refs/heads/master","pushedAt":"2024-08-11T15:14:43.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"sakertooth","name":"saker","path":"/sakertooth","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20197645?s=80&v=4"},"commit":{"message":"Add input dialog to the mixer channel LCD spin box (#7399)\n\nCo-authored-by: saker <sakertooth@gmail.com>","shortMessageHtmlLink":"Add input dialog to the mixer channel LCD spin box (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2433519380\" data-permission-text=\"Title is private\" data-url=\"https://github.com/LMMS/lmms/issues/7399\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/LMMS/lmms/pull/7399/hovercard\" href=\"https://github.com/LMMS/lmms/pull/7399\">#7399</a>)"}},{"before":"0e96c267cde8a8a99bc441d66ef394d25b1b9500","after":"d8e4d8c115d2e7b34943d01223c574327cd1a173","ref":"refs/heads/master","pushedAt":"2024-08-11T10:20:02.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"michaelgregorius","name":"Michael Gregorius","path":"/michaelgregorius","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9293269?s=80&v=4"},"commit":{"message":"Remove support for SDL1 (#7443)\n\nRemove the fallback code in `CMakeLists.txt`. Keep the message that's shown when SDL is wanted but not found. Remove the specific `LMMS_HAVE_SDL2` define.\r\n\r\nJust print \"OK\" if SDL is found.\r\n\r\nRemove several ifdefs which check for SDL2 or SDL1. Remove all code related to SDL1.","shortMessageHtmlLink":"Remove support for SDL1 (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2459296972\" data-permission-text=\"Title is private\" data-url=\"https://github.com/LMMS/lmms/issues/7443\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/LMMS/lmms/pull/7443/hovercard\" href=\"https://github.com/LMMS/lmms/pull/7443\">#7443</a>)"}},{"before":"74c73e5848651d244789f66c6ef98ce6976183b6","after":"0e96c267cde8a8a99bc441d66ef394d25b1b9500","ref":"refs/heads/master","pushedAt":"2024-08-11T02:39:55.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"sakertooth","name":"saker","path":"/sakertooth","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20197645?s=80&v=4"},"commit":{"message":"Fix bug with continuous autoscrolling when smooth scrolling is enabled (#7433)","shortMessageHtmlLink":"Fix bug with continuous autoscrolling when smooth scrolling is enabled ("}},{"before":"44a8b038f5587600559f94e66d566abf279ec374","after":"74c73e5848651d244789f66c6ef98ce6976183b6","ref":"refs/heads/master","pushedAt":"2024-08-10T20:33:52.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"michaelgregorius","name":"Michael Gregorius","path":"/michaelgregorius","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9293269?s=80&v=4"},"commit":{"message":"SDL driver's input and output device configuration via combo box (#7421)\n\n* Enable configuration of input device for SDL\r\n\r\nUp to now the SDL audio driver attempted to use the default recording\r\ndevice. This might not be what users want or expect, especially since the\r\nactually used device is not visible anywhere. So if recording does not\r\nwork for the users they have no way to find out what's wrong.\r\n\r\nExtend the settings screen of the SDL driver with a combo box that allows\r\nto select the input device to be used. Store the selected device name in\r\na new attribute called \"inputdevice\" in the \"audiosdl\" section of the\r\nconfiguration file.\r\n\r\nUse the information from the configuration when attempting to inialize\r\nthe input device. Fall back to the default device if that does not work.\r\n\r\n(cherry picked from commit 33139b9f4c7a4844d3e101cbf1887823fbec776a)\r\n\r\n* Provide a setting for system default input\r\n\r\nProvide the setting \"[System Default]\" which instructs the SDL driver to\r\nuse the default device of the system as the input device. In the\r\nconfiguration file this option is represented as an empty string. This\r\nshould play well with the current existing configuration of the users.\r\n\r\n(cherry picked from commit 29c43c2bb66033bd44787b3207e70ce0d31c845d)\r\n\r\n* Configuration of output device for SDL\r\n\r\nLet users configure the output device that's used by the SDL driver.\r\nCode-wise the implementation is very similar to the input device\r\nconfiguration.\r\n\r\nUse a `QComboBox` instead of a `QLineEdit` for `m_device` and rename it\r\nto `m_playbackDeviceComboBox`.\r\n\r\nRename `s_defaultInputDevice` to `s_systemDefaultDevice` because it is\r\nused in the context of playback and input devices.\r\n\r\n(cherry picked from commit 1ab45e4994851d5a629db4a22d7825f79386ef5d)\r\n\r\n* Ensure label visibility\r\n\r\nMake sure that labels are always shown by setting the row wrap policy of\r\nthe form layout to wrap long rows.\r\n\r\n(cherry picked from commit a123d0e3cb62745b83d9304747445ff73e1345fb)\r\n\r\n* Rename \"Device\"\r\n\r\nRename \"Device\" to \"Playback device\" to make clear what the setting\r\nrefers to.\r\n\r\n(cherry picked from commit 1f0cda4983f66a0d3a9f024ae3ee2d57c7bf59e6)\r\n\r\n* Remove repeated strings\r\n\r\nIntroduce const expressions to get rid of repeated strings with a risk\r\nof typos.\r\n\r\n(cherry picked from commit f9ea9705b8780298d78e3010053ae026a64aacee)\r\n\r\n* Apply some more changes\r\n\r\nApply some more changes that have been made to `AudioSdl` in the\r\nrecording branch.\r\n\r\n* Conditional ternary operator\r\n\r\nAlso use a conditional ternary operator for the input device setup.\r\n\r\n* Methods for population of combo boxes\r\n\r\nMove the population of the input and playback device combo boxes into\r\nthe methods `populatePlaybackDeviceComboBox` and\r\n`populateInputDeviceComboBox`.\r\n\r\n* Sort devices in combo box\r\n\r\nSort the devices names alphabetically in the input and playback combo\r\nboxes. The default devices is always shown as the first entry.\r\n\r\n* Code review fixes\r\n\r\nUse `AudioDeviceSetupWidget` instead of `QObject` to translate \"[System\r\nDefault]\".\r\n\r\nFix copy/paste error in comment.\r\n\r\n* Simplify some constexpr statements","shortMessageHtmlLink":"SDL driver's input and output device configuration via combo box (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2446618615\" data-permission-text=\"Title is private\" data-url=\"https://github.com/LMMS/lmms/issues/7421\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/LMMS/lmms/pull/7421/hovercard\" href=\"https://github.com/LMMS/lmms/pull/7421\">#7421</a>)"}},{"before":"632966caeecbc169625fe8f9dc6dbdb607606659","after":"44a8b038f5587600559f94e66d566abf279ec374","ref":"refs/heads/master","pushedAt":"2024-08-10T03:30:06.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Rossmaxx","name":"Rossmaxx","path":"/Rossmaxx","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/74815851?s=80&v=4"},"commit":{"message":"Fix #5851: Implement `EffectRackView::sizeHint()` (#7428)\n\n* Fix #5851: Implement `EffectRackView::sizeHint()`\r\n\r\nThis fixes `EffectRackView` to have a permanent size hint instead of\r\nresizing the widget once in `InstrumentTrackWindow`. The size hint tells\r\nthe `InstrumentTrackWindow` to not increase with a growing number of\r\neffects in the `EffectRackView`.","shortMessageHtmlLink":"<span class=\"issue-keyword tooltipped tooltipped-se\" aria-label=\"This commit closes issue #5851.\">Fix</span> <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"771095153\" data-permission-text=\"Title is private\" data-url=\"https://github.com/LMMS/lmms/issues/5851\" data-hovercard-type=\"issue\" data-hovercard-url=\"/LMMS/lmms/issues/5851/hovercard\" href=\"https://github.com/LMMS/lmms/issues/5851\">#5851</a>: Implement <code>EffectRackView::sizeHint()</code> (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2447347353\" data-permission-text=\"Title is private\" data-url=\"https://github.com/LMMS/lmms/issues/7428\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/LMMS/lmms/pull/7428/hovercard\" href=\"https://github.com/LMMS/lmms/pull/7428\">#7428</a>)"}},{"before":"6c7fecd8d7b729b4ad83187f511f7b93ab1430ff","after":"632966caeecbc169625fe8f9dc6dbdb607606659","ref":"refs/heads/master","pushedAt":"2024-08-07T17:12:37.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"sakertooth","name":"saker","path":"/sakertooth","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20197645?s=80&v=4"},"commit":{"message":"Do not put the main thread in realtime or high priority (#7436)","shortMessageHtmlLink":"Do not put the main thread in realtime or high priority (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2451780542\" data-permission-text=\"Title is private\" data-url=\"https://github.com/LMMS/lmms/issues/7436\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/LMMS/lmms/pull/7436/hovercard\" href=\"https://github.com/LMMS/lmms/pull/7436\">#7436</a>)"}},{"before":"828cefb4eacf460f558b7cfafb6b9210da54d7ac","after":"6c7fecd8d7b729b4ad83187f511f7b93ab1430ff","ref":"refs/heads/master","pushedAt":"2024-08-07T03:23:17.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"sakertooth","name":"saker","path":"/sakertooth","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20197645?s=80&v=4"},"commit":{"message":"Fix build regression from #7380 (#7437)","shortMessageHtmlLink":"Fix build regression from <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2408405844\" data-permission-text=\"Title is private\" data-url=\"https://github.com/LMMS/lmms/issues/7380\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/LMMS/lmms/pull/7380/hovercard\" href=\"https://github.com/LMMS/lmms/pull/7380\">#7380</a> (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2452071576\" data-permission-text=\"Title is private\" data-url=\"https://github.com/LMMS/lmms/issues/7437\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/LMMS/lmms/pull/7437/hovercard\" href=\"https://github.com/LMMS/lmms/pull/7437\">#7437</a>)"}},{"before":"c16616cca4c12ac558ea393f76146ea3e5a58751","after":"828cefb4eacf460f558b7cfafb6b9210da54d7ac","ref":"refs/heads/master","pushedAt":"2024-08-07T02:03:10.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Rossmaxx","name":"Rossmaxx","path":"/Rossmaxx","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/74815851?s=80&v=4"},"commit":{"message":"Remove `typeInfo` struct from `lmms_basics.h` (#7380)\n\n* remove typeInfo struct from lmms_basics.h\r\n\r\n* Code review\r\n\r\nCo-authored-by: saker <sakertooth@gmail.com>\r\n\r\n* converted epsilon to a constant\r\n\r\n* renamed to approximatelyEqual and moved to top\r\n\r\n---------\r\n\r\nCo-authored-by: saker <sakertooth@gmail.com>","shortMessageHtmlLink":"Remove <code>typeInfo</code> struct from <code>lmms_basics.h</code> (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2408405844\" data-permission-text=\"Title is private\" data-url=\"https://github.com/LMMS/lmms/issues/7380\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/LMMS/lmms/pull/7380/hovercard\" href=\"https://github.com/LMMS/lmms/pull/7380\">#7380</a>)"}},{"before":"5b366cfe3cc4f22b06f7385b63d00117f7c9529d","after":"c16616cca4c12ac558ea393f76146ea3e5a58751","ref":"refs/heads/master","pushedAt":"2024-08-05T11:16:03.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"sakertooth","name":"saker","path":"/sakertooth","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20197645?s=80&v=4"},"commit":{"message":"Fix duplication of solo state when cloning tracks (#7391)","shortMessageHtmlLink":"Fix duplication of solo state when cloning tracks (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2426994702\" data-permission-text=\"Title is private\" data-url=\"https://github.com/LMMS/lmms/issues/7391\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/LMMS/lmms/pull/7391/hovercard\" href=\"https://github.com/LMMS/lmms/pull/7391\">#7391</a>)"}},{"before":"9745a49ae3b2df0b0564e6f04de3fde352b3b76c","after":null,"ref":"refs/heads/revert-7361-fix-libsamplerate-usage-sample","pushedAt":"2024-08-04T15:01:29.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"sakertooth","name":"saker","path":"/sakertooth","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20197645?s=80&v=4"}},{"before":"735e483d9fc1d5072b8ec9ccf122f97339e7d6c2","after":"5b366cfe3cc4f22b06f7385b63d00117f7c9529d","ref":"refs/heads/master","pushedAt":"2024-08-04T15:01:26.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"sakertooth","name":"saker","path":"/sakertooth","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20197645?s=80&v=4"},"commit":{"message":"Revert \"Switch to libsamplerate's callback API in `Sample` (#7361)\" (#7410)\n\nThis reverts commit 2f5f12aaae8453863f62305cb54e4cfe779b661c.","shortMessageHtmlLink":"Revert \"Switch to libsamplerate's callback API in <code>Sample</code> (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2385936080\" data-permission-text=\"Title is private\" data-url=\"https://github.com/LMMS/lmms/issues/7361\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/LMMS/lmms/pull/7361/hovercard\" href=\"https://github.com/LMMS/lmms/pull/7361\">#7361</a>)\" (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2438765176\" data-permission-text=\"Title is private\" data-url=\"https://github.com/LMMS/lmms/issues/7410\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/LMMS/lmms/pull/7410/hovercard\" href=\"https://github.com/LMMS/lmms/pull/7410\">#…</a>"}},{"before":"8a83a17728dade7f08f801c62c643bbabef11177","after":null,"ref":"refs/heads/fix-memleak-help-2","pushedAt":"2024-08-04T14:21:55.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Rossmaxx","name":"Rossmaxx","path":"/Rossmaxx","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/74815851?s=80&v=4"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEux2olwA","startCursor":null,"endCursor":null}},"title":"Activity · LMMS/lmms"}