From ded85eaec7d7a25b755890b19c1c5829ea60ea6b Mon Sep 17 00:00:00 2001
From: Michael Gregorius <michael.gregorius.git@arcor.de>
Date: Thu, 10 Oct 2024 18:21:55 +0200
Subject: [PATCH] Remove deprecated code in GigPlayer

Use `CountInstruments` and `GetInstrument` instead of the deprecated
methods `GetFirstInstrument` and `GetNextInstrument`.

Use `CountRegions` and `GetRegionAt` instead of the deprecated
`GetFirstRegion` and `GetNextRegion`.

Both changes turn `while` loops into `for` loops.
---
 plugins/GigPlayer/GigPlayer.cpp     | 42 +++++++++++------------------
 plugins/GigPlayer/PatchesDialog.cpp | 16 +++++------
 2 files changed, 21 insertions(+), 37 deletions(-)

diff --git a/plugins/GigPlayer/GigPlayer.cpp b/plugins/GigPlayer/GigPlayer.cpp
index b72e30b3335..7fb66d5708d 100644
--- a/plugins/GigPlayer/GigPlayer.cpp
+++ b/plugins/GigPlayer/GigPlayer.cpp
@@ -260,26 +260,19 @@ QString GigInstrument::getCurrentPatchName()
 	int iBankSelected = m_bankNum.value();
 	int iProgSelected = m_patchNum.value();
 
-	gig::Instrument * pInstrument = m_instance->gig.GetFirstInstrument();
-
-	while( pInstrument != nullptr )
+	for (size_t i = 0; i < m_instance->gig.CountInstruments(); ++i)
 	{
+		auto pInstrument = m_instance->gig.GetInstrument(i);
+
 		int iBank = pInstrument->MIDIBank;
 		int iProg = pInstrument->MIDIProgram;
 
-		if( iBank == iBankSelected && iProg == iProgSelected )
+		if (iBank == iBankSelected && iProg == iProgSelected)
 		{
-			QString name = QString::fromStdString( pInstrument->pInfo->Name );
+			QString name = QString::fromStdString(pInstrument->pInfo->Name);
 
-			if( name == "" )
-			{
-				name = "<no name>";
-			}
-
-			return name;
+			return name.isEmpty() ? "<no name>" : name;
 		}
-
-		pInstrument = m_instance->gig.GetNextInstrument();
 	}
 
 	return "";
@@ -719,10 +712,10 @@ void GigInstrument::addSamples( GigNote & gignote, bool wantReleaseSample )
 					m_instrument->DimensionKeyRange.low + 1 );
 	}
 
-	gig::Region* pRegion = m_instrument->GetFirstRegion();
-
-	while( pRegion != nullptr )
+	for (size_t i = 0; i < m_instrument->CountRegions(); ++i)
 	{
+		gig::Region* pRegion = m_instrument->GetRegionAt(i);
+
 		Dimension dim = getDimensions( pRegion, gignote.velocity, wantReleaseSample );
 		gig::DimensionRegion * pDimRegion = pRegion->GetDimensionRegionByValue( dim.DimValues );
 		gig::Sample * pSample = pDimRegion->pSample;
@@ -764,8 +757,6 @@ void GigInstrument::addSamples( GigNote & gignote, bool wantReleaseSample )
 							attenuation, m_interpolation, gignote.frequency ) );
 			}
 		}
-
-		pRegion = m_instrument->GetNextRegion();
 	}
 }
 
@@ -863,22 +854,19 @@ void GigInstrument::getInstrument()
 
 	if( m_instance != nullptr )
 	{
-		gig::Instrument * pInstrument = m_instance->gig.GetFirstInstrument();
-
-		while( pInstrument != nullptr )
+		for (size_t i = 0; i < m_instance->gig.CountInstruments(); ++i)
 		{
+			gig::Instrument* pInstrument = m_instance->gig.GetInstrument(i);
+
 			int iBank = pInstrument->MIDIBank;
 			int iProg = pInstrument->MIDIProgram;
 
-			if( iBank == iBankSelected && iProg == iProgSelected )
+			if (iBank == iBankSelected && iProg == iProgSelected)
 			{
-				break;
+				m_instrument = pInstrument;
+				return;
 			}
-
-			pInstrument = m_instance->gig.GetNextInstrument();
 		}
-
-		m_instrument = pInstrument;
 	}
 }
 
diff --git a/plugins/GigPlayer/PatchesDialog.cpp b/plugins/GigPlayer/PatchesDialog.cpp
index c78c99f2c2b..db8180b7156 100644
--- a/plugins/GigPlayer/PatchesDialog.cpp
+++ b/plugins/GigPlayer/PatchesDialog.cpp
@@ -143,10 +143,10 @@ void PatchesDialog::setup( GigInstance * pSynth, int iChan,
 	int iBankDefault = -1;
 	int iProgDefault = -1;
 
-	gig::Instrument * pInstrument = m_pSynth->gig.GetFirstInstrument();
-
-	while( pInstrument )
+	for (size_t i = 0; i < m_pSynth->gig.CountInstruments(); ++i)
 	{
+		gig::Instrument * pInstrument = m_pSynth->gig.GetInstrument(i);
+
 		int iBank = pInstrument->MIDIBank;
 		int iProg = pInstrument->MIDIProgram;
 
@@ -165,8 +165,6 @@ void PatchesDialog::setup( GigInstance * pSynth, int iChan,
 				}
 			}
 		}
-
-		pInstrument = m_pSynth->gig.GetNextInstrument();
 	}
 
 	m_bankListView->setSortingEnabled( true );
@@ -341,10 +339,10 @@ void PatchesDialog::bankChanged()
 	m_progListView->clear();
 	QTreeWidgetItem * pProgItem = nullptr;
 
-	gig::Instrument * pInstrument = m_pSynth->gig.GetFirstInstrument();
-
-	while( pInstrument )
+	for (size_t i = 0; i < m_pSynth->gig.CountInstruments(); ++i)
 	{
+		gig::Instrument * pInstrument = m_pSynth->gig.GetInstrument(i);
+
 		QString name = QString::fromStdString( pInstrument->pInfo->Name );
 
 		if( name == "" )
@@ -365,8 +363,6 @@ void PatchesDialog::bankChanged()
 				pProgItem->setText( 1, name );
 			}
 		}
-
-		pInstrument = m_pSynth->gig.GetNextInstrument();
 	}
 
 	m_progListView->setSortingEnabled( true );