Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in stacked weights computation #610

Closed
combet opened this issue Oct 19, 2023 · 1 comment · Fixed by #611
Closed

Bug in stacked weights computation #610

combet opened this issue Oct 19, 2023 · 1 comment · Fixed by #611
Assignees
Labels
priority Essential for current milestone

Comments

@combet
Copy link
Collaborator

combet commented Oct 19, 2023

Running the demo_mock_ensemble notebook, the output of cell 11 has the values of the n_src column in the W_l column. I think (but need to double check) the latter should correspond to the sum of the individual weights w_ls computed in cell 6.

I don't know if the problem has always been there or has been introduced in a recent change. But this is a bug and needs to be looked at (I noticed it while implementing things in TXPipe...)

@combet combet added the bug Something isn't working label Oct 19, 2023
@combet combet added the priority Essential for current milestone label Oct 19, 2023
@combet combet changed the title Bug in weights computation Bug in stacked weights computation Oct 19, 2023
@combet combet removed the bug Something isn't working label Oct 19, 2023
@combet
Copy link
Collaborator Author

combet commented Oct 19, 2023

OK - it was not actually a bug but simply a missing use_weights options in the notebook, that I also forgot when adding code to TXPipe. All good I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority Essential for current milestone
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants