Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site continuously reloading #1493

Closed
paaspaas00 opened this issue Sep 22, 2024 · 2 comments · Fixed by #1522
Closed

Site continuously reloading #1493

paaspaas00 opened this issue Sep 22, 2024 · 2 comments · Fixed by #1522
Labels
bug Something isn't working has repro We have a way to reproduce this bug. reduction of web content Issue has a simplified reduction based on real-world web content.

Comments

@paaspaas00
Copy link
Contributor

paaspaas00 commented Sep 22, 2024 •
edited
Loading

Hi, I've tried to load https://docs.lvgl.io/8.4/porting/indev.html#encoder with Ladybird latest (76662d2).
The site continuously reloads after loading a good portion of the page. Here's what I see in the terminal:

33386.913 WebContent(199888): ResourceLoader: Filtered request to: "https://www.googletagmanager.com/gtag/js?id=UA-78811084-3"
33387.273 WebContent(199888): HTMLScriptElement: Refusing to run script because the element's result is null.
33387.633 WebContent(199888): ResourceLoader: Failed load of: "https://lvgl.io/home-banner.txt", Error: Load failed: 404, Duration: 460ms
33387.703 WebContent(199888): (js error) "Fetch error: HTTP error! Status: 404"
33388.653 WebContent(199888): No property (from 2 properties) matched Token: Ident: dotted
33388.653 WebContent(199888):     outline-color
33388.653 WebContent(199888):     outline-style
33388.693 WebContent(199888): No property (from 4 properties) matched Token: Ident: none
33388.693 WebContent(199888):     padding-top
33388.693 WebContent(199888):     padding-right
33388.693 WebContent(199888):     padding-bottom
33388.693 WebContent(199888):     padding-left
33388.763 WebContent(199888): No property (from 2 properties) matched Token: Ident: dotted
33388.763 WebContent(199888):     outline-color
33388.763 WebContent(199888):     outline-style
33389.233 WebContent(199888): ResourceLoader: Filtered request to: "https://www.googletagmanager.com/gtag/js?id=UA-78811084-3"
33389.593 WebContent(199888): HTMLScriptElement: Refusing to run script because the element's result is null.
33389.863 WebContent(199888): ResourceLoader: Failed load of: "https://lvgl.io/home-banner.txt", Error: Load failed: 404, Duration: 380ms
33389.903 WebContent(199888): (js error) "Fetch error: HTTP error! Status: 404"
33390.803 WebContent(199888): No property (from 2 properties) matched Token: Ident: dotted
33390.803 WebContent(199888):     outline-color
33390.803 WebContent(199888):     outline-style
33390.833 WebContent(199888): No property (from 4 properties) matched Token: Ident: none
33390.833 WebContent(199888):     padding-top
33390.833 WebContent(199888):     padding-right
33390.833 WebContent(199888):     padding-bottom
33390.833 WebContent(199888):     padding-left
33390.903 WebContent(199888): No property (from 2 properties) matched Token: Ident: dotted
33390.903 WebContent(199888):     outline-color
33390.903 WebContent(199888):     outline-style
33391.443 WebContent(199888): ResourceLoader: Filtered request to: "https://www.googletagmanager.com/gtag/js?id=UA-78811084-3"
33391.793 WebContent(199888): HTMLScriptElement: Refusing to run script because the element's result is null.
33392.073 WebContent(199888): ResourceLoader: Failed load of: "https://lvgl.io/home-banner.txt", Error: Load failed: 404, Duration: 390ms
33392.143 WebContent(199888): (js error) "Fetch error: HTTP error! Status: 404"
33393.383 WebContent(199888): No property (from 2 properties) matched Token: Ident: dotted
33393.383 WebContent(199888):     outline-color
33393.383 WebContent(199888):     outline-style
33393.463 WebContent(199888): No property (from 2 properties) matched Token: Ident: dotted
33393.463 WebContent(199888):     outline-color
33393.463 WebContent(199888):     outline-style
33393.473 WebContent(199888): No property (from 4 properties) matched Token: Ident: none
33393.473 WebContent(199888):     padding-top
33393.473 WebContent(199888):     padding-right
33393.473 WebContent(199888):     padding-bottom
33393.473 WebContent(199888):     padding-left
33393.993 WebContent(199888): ResourceLoader: Filtered request to: "https://www.googletagmanager.com/gtag/js?id=UA-78811084-3"
33394.623 WebContent(199888): HTMLScriptElement: Refusing to run script because the element's result is null.
33395.033 WebContent(199888): ResourceLoader: Failed load of: "https://lvgl.io/home-banner.txt", Error: Load failed: 404, Duration: 511ms
33395.073 WebContent(199888): (js error) "Fetch error: HTTP error! Status: 404"
33395.943 WebContent(199888): No property (from 2 properties) matched Token: Ident: dotted
33395.953 WebContent(199888):     outline-color
33395.953 WebContent(199888):     outline-style
33396.043 WebContent(199888): No property (from 2 properties) matched Token: Ident: dotted
33396.043 WebContent(199888):     outline-color
33396.043 WebContent(199888):     outline-style
33396.063 WebContent(199888): No property (from 4 properties) matched Token: Ident: none
33396.063 WebContent(199888):     padding-top
33396.063 WebContent(199888):     padding-right
33396.063 WebContent(199888):     padding-bottom
33396.063 WebContent(199888):     padding-left
33396.723 WebContent(199888): ResourceLoader: Filtered request to: "https://www.googletagmanager.com/gtag/js?id=UA-78811084-3"
33397.123 WebContent(199888): HTMLScriptElement: Refusing to run script because the element's result is null.
33397.403 WebContent(199888): ResourceLoader: Failed load of: "https://lvgl.io/home-banner.txt", Error: Load failed: 404, Duration: 421ms
33397.453 WebContent(199888): (js error) "Fetch error: HTTP error! Status: 404"
33398.823 WebContent(199888): No property (from 2 properties) matched Token: Ident: dotted
33398.823 WebContent(199888):     outline-color
33398.823 WebContent(199888):     outline-style
33398.923 WebContent(199888): No property (from 2 properties) matched Token: Ident: dotted
33398.923 WebContent(199888):     outline-color
33398.923 WebContent(199888):     outline-style
33398.953 WebContent(199888): No property (from 4 properties) matched Token: Ident: none
33398.953 WebContent(199888):     padding-top
33398.953 WebContent(199888):     padding-right
33398.953 WebContent(199888):     padding-bottom
33398.953 WebContent(199888):     padding-left
33399.523 WebContent(199888): ResourceLoader: Filtered request to: "https://www.googletagmanager.com/gtag/js?id=UA-78811084-3"
33399.893 WebContent(199888): HTMLScriptElement: Refusing to run script because the element's result is null.
33400.183 WebContent(199888): ResourceLoader: Failed load of: "https://lvgl.io/home-banner.txt", Error: Load failed: 404, Duration: 400ms
33400.243 WebContent(199888): (js error) "Fetch error: HTTP error! Status: 404"
33401.383 WebContent(199888): No property (from 4 properties) matched Token: Ident: none
33401.383 WebContent(199888):     padding-top
33401.383 WebContent(199888):     padding-right
33401.383 WebContent(199888):     padding-bottom
33401.383 WebContent(199888):     padding-left
33401.543 WebContent(199888): No property (from 2 properties) matched Token: Ident: dotted
33401.543 WebContent(199888):     outline-color
33401.543 WebContent(199888):     outline-style
33401.623 WebContent(199888): No property (from 2 properties) matched Token: Ident: dotted
33401.623 WebContent(199888):     outline-color
33401.623 WebContent(199888):     outline-style
33402.523 WebContent(199888): ResourceLoader: Filtered request to: "https://www.googletagmanager.com/gtag/js?id=UA-78811084-3"
33402.873 WebContent(199888): HTMLScriptElement: Refusing to run script because the element's result is null.
33403.163 WebContent(199888): ResourceLoader: Failed load of: "https://lvgl.io/home-banner.txt", Error: Load failed: 404, Duration: 410ms
33403.723 WebContent(199888): (js error) "Fetch error: HTTP error! Status: 404"
@neil-ptr
Copy link
Contributor

I've also seen this behaviour on https://rust-lang.org

@tcl3
Copy link
Member

tcl3 commented Sep 23, 2024

The issue seems to be that onchange is being called when it shouldn't be for <select> elements.

Reduced to:

<!DOCTYPE html>
<select id="selectElement">
    <option value="1">Test 1</option>
    <option value="2">Test 2</option>
</select>
<script>
    const selectElement = document.querySelector("select");
    selectElement.value = "2";
    selectElement.onchange = () => {
        console.log("onchange called");
        window.location = "";
    }
</script>

@tcl3 tcl3 added bug Something isn't working reduction of web content Issue has a simplified reduction based on real-world web content. has repro We have a way to reproduce this bug. labels Sep 23, 2024
@Arhcout Arhcout mentioned this issue Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working has repro We have a way to reproduce this bug. reduction of web content Issue has a simplified reduction based on real-world web content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

LibWeb: Select element will not trigger onchange when using element.value Arhcout/ladybird
3 participants
@tcl3 @neil-ptr @paaspaas00