Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<TBODY> are getting superfluous overflow #1525

Open
ebanner opened this issue Sep 25, 2024 · 3 comments · May be fixed by #1542
Open

<TBODY> are getting superfluous overflow #1525

ebanner opened this issue Sep 25, 2024 · 3 comments · May be fixed by #1542
Labels
bug Something isn't working has repro We have a way to reproduce this bug. layout

Comments

@ebanner
Copy link
Contributor

ebanner commented Sep 25, 2024

<TBODY> elements are getting overflow when presumably they shouldn't. For example:

<table>
  <tbody>
    <tr>
      <td>Cell 1</td>
    </tr>
  </tbody>
</table>

This produces the following overflow on <TBODY>:

Box<TBODY>: RECT: 8, 8, [38.6875x16]
Box<TBODY>: CHILD Box<TR> RECT: 10, 10, [38.6875x16]
Box<TBODY>: SCROLLABLE OVERFLOW: 8, 8, [40.6875x18]

As you can see, there are two potential issues which are causing the <TBODY> to get overflow:

  1. The child <TR> has an offset of 2, 2 into the <TBODY>
  2. The <TBODY> isn't growing tall and wide enough to contain the <TR>

I'm not sure which of these root cause is - whether <TR> should have no offset, or whether the table should be growing to contain its children (or maybe both are issues?).

On chrome, the <TR> elements don't have an offset - they overlap with <TBODY>.

@AtkinsSJ
Copy link
Member

As a guess: Are we ignoring the cellspacing value when deciding how big to make the table? You could see if adding style="border-collapse: collapse" to the table element helps.

@ebanner
Copy link
Contributor Author

ebanner commented Sep 25, 2024

Yeah, that makes the overflow go away!

@ebanner ebanner linked a pull request Sep 26, 2024 that will close this issue
48 tasks
@ebanner
Copy link
Contributor Author

ebanner commented Sep 30, 2024

Seems like both tr and tbody aren't taking into account cell spacing:

image

image

@AtkinsSJ AtkinsSJ added bug Something isn't working has repro We have a way to reproduce this bug. layout labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working has repro We have a way to reproduce this bug. layout
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants