Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade DateInput to use ^4.0.0 of react-datepicker #305

Closed
chawes13 opened this issue Nov 29, 2018 · 2 comments · Fixed by #558
Closed

Upgrade DateInput to use ^4.0.0 of react-datepicker #305

chawes13 opened this issue Nov 29, 2018 · 2 comments · Fixed by #558
Assignees
Milestone

Comments

@chawes13
Copy link
Contributor

As of 2.0.0, there is no longer a moment dependency (important for bundle size considerations)

@dpikt dpikt added this to the v3 enhancements milestone Nov 29, 2018
@dpikt
Copy link
Contributor

dpikt commented Apr 29, 2019

So, we tried this out in #332. Turns out the library is a little too unreliable to make the switch at this moment. I think we should keep our eye on it and try again in a few releases, since it's a pretty widely used library and I have faith in the crowd to iron it out eventually.

In the meantime we could also investigate another solution (per #273) but a lot of those have a moment dependency too...

@chawes13
Copy link
Contributor Author

React datepicker is on 4.2.1 now. We should investigate making the upgrade

https://www.npmjs.com/package/react-datepicker

@chawes13 chawes13 changed the title Upgrade DateInput to use ^2.0.0 of reactdatepicker Upgrade DateInput to use ^4.0.0 of react-datepicker Aug 31, 2021
@chawes13 chawes13 modified the milestones: v5 enhancements, v6 Aug 31, 2021
@chawes13 chawes13 self-assigned this Jan 11, 2022
@chawes13 chawes13 linked a pull request Jun 22, 2022 that will close this issue
5 tasks
@chawes13 chawes13 mentioned this issue Jun 23, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants