Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defaulting to the body element breaks a11y on Firefox #496

Closed
chawes13 opened this issue Oct 22, 2021 · 0 comments · Fixed by #559
Closed

Defaulting to the body element breaks a11y on Firefox #496

chawes13 opened this issue Oct 22, 2021 · 0 comments · Fixed by #559
Assignees
@chawes13
Labels
a11y Accessibility bug help wanted
Milestone
v7

Comments

@chawes13
Copy link
Contributor

When aria-hidden="true" is applied to the body, VoiceOver on Firefox will ignore all content in the window. Instead, we could default to #root or main.

reactjs/react-modal#359
@chawes13 chawes13 added bug a11y Accessibility labels Oct 22, 2021
@chawes13 chawes13 changed the title Defaulting to the body element breaks on Firefox Defaulting to the body element breaks a11y on Firefox Oct 22, 2021
@chawes13 chawes13 self-assigned this Jan 11, 2022
@chawes13 chawes13 mentioned this issue Jun 23, 2022
Merged
5 tasks
@chawes13 chawes13 linked a pull request Jun 23, 2022 that will close this issue
Bug/react modal default #559
Merged
5 tasks
@chawes13 chawes13 mentioned this issue Jun 23, 2022
Merged
5 tasks
@chawes13 chawes13 added this to the v7 milestone Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chawes13 chawes13

Labels
a11y Accessibility bug help wanted
Projects
None yet
Milestone
v7
Development

Successfully merging a pull request may close this issue.

Bug/react modal default LaunchPadLab/lp-components
1 participant
@chawes13