Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SetterLink component #524

Closed
chawes13 opened this issue Jan 18, 2022 · 4 comments · Fixed by #528
Closed

Remove SetterLink component #524

chawes13 opened this issue Jan 18, 2022 · 4 comments · Fixed by #528
Labels
Milestone

Comments

@chawes13
Copy link
Contributor

Instead of using this component, we should be pushing devs to use semantic form elements (e.g., checkbox, radio group, or select).

Not only is this not a semantic element, it's also an inappropriate use of an anchor tag, since it's not used for navigation and is not in the tab order. Source: http://itstiredinhere.blogspot.com/2014/08/the-anchor-button-bad-for-accessibility.html.

@chawes13 chawes13 added this to the v6 milestone Jan 18, 2022
@chawes13
Copy link
Contributor Author

@bhennes2 @inveterateliterate @dianacamacho Are you aware of any projects currently using this component? I did a search and found it in mmrf and uolf. I recently had a conversation with Nikki about replacing it on uolf, so there may not be any other active projects using it. Let me know if you have any concerns with removing it!

@chawes13 chawes13 added the idea label Jan 18, 2022
@inveterateliterate
Copy link
Contributor

I have not seen this in the projects I have been active on!

@dianacamacho
Copy link

Outside of uolf, i dont think so!

@chawes13 chawes13 mentioned this issue Jan 19, 2022
5 tasks
@bhennes2
Copy link

MMRF is idle so should have to worry about backwards compatibility there.

@chawes13 chawes13 assigned chawes13 and unassigned chawes13 Jun 16, 2022
@chawes13 chawes13 linked a pull request Jun 16, 2022 that will close this issue
5 tasks
@chawes13 chawes13 mentioned this issue Jun 23, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants