Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for aria-describedby prop on Checkbox input #533

Open
danparnella opened this issue Feb 9, 2022 · 1 comment
Open

Allow for aria-describedby prop on Checkbox input #533

danparnella opened this issue Feb 9, 2022 · 1 comment
Assignees

Comments

@danparnella
Copy link
Contributor

Currently, the aria-describedby value can only be set to an input error and otherwise is set to null [Reference]. Ideally, we can pass in an ariaDescribedby prop that would be used as the fallback when there is no input error.

@danparnella danparnella self-assigned this Feb 9, 2022
@chawes13
Copy link
Contributor

chawes13 commented Feb 9, 2022

I believe you can override aria-describedby by passing in that prop exactly to the component (unless filterInvalidDOMProps overrides that. The issue with that though is that it should not override aria-describedby when there is an error

Example: https://codesandbox.io/s/adoring-wozniak-mf4ys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants