Allow Class Specification on TableColumn #637
Conversation
|
@Ramy-Huffman-LPL I'm going to pull myself off of the review until this PR is converted from a draft. LMK if you have any questions in the meantime! |
|
@Ramy-Huffman-LPL FYI if you use keywords like "Resolves " in front of your link to the issue, it will not only link it to the Development section of this PR, it will also autoclose it when the PR is merged! Here's more info: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue |
| </SortableTable> | ||
| ) | ||
|
|
||
| const header = screen.getByText('Name').closest('th') |
There was a problem hiding this comment.
Why do you need closest here? When I printed out the value for screen.getByText('Name'), it was the header itself 🤔
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@launchpadlab/lp-components", | |||
| "version": "10.0.1", | |||
| "version": "10.1.0", | |||
There was a problem hiding this comment.
I think we have to qualify this as a breaking change and add some notes to a migration guide.
Any styles that are only applied to a class passed in to a column will be applied to headers as well. In the notes, we should add that if the user does not wish for these styles to apply, then they must include a more specific selector that includes the element, e.g., td.foo {} instead of just .foo {}
|
@Ramy-Huffman-LPL will you be able to pick this back up this quarter? |
This is in reference to an enhancement to add to a
Tableand pass a custom classname.Release Notes
Author Checklist