Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Storybook link on README.md #642

Open
JoseWhite opened this issue Jun 6, 2024 · 0 comments
Open

Broken Storybook link on README.md #642

JoseWhite opened this issue Jun 6, 2024 · 0 comments

Comments

@JoseWhite
Copy link

Environment

  • @launchpad/lp-components version: 10.1.0
  • react version: 18.0.0
  • node version: 20.11.1

Expected Behavior

The storybook link in the readme links to the storybook site, github page or main documentation

Current Behavior

The link forwards to a page with a "Account has been suspended mesage asking for contact with the dns provider maxoko, likely where storybook's owners used to and no longer host their domain
image

Steps to Reproduce

Clicking the "React storybook" link in the readme should suffice. See image below.
image

Suggested Solution

  • https://storybook.js.org seems to be the new domain for storybook, let's make the link forward to that instead?
    image

  • We could also change this link to forward to storybook's github page at https://github.com/storybookjs/storybook, I feel this is less likely to change and we are also likely to find a link there to the public facing page of storybook, as can be seen in the image below.
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant