Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DISCUSSION] Add generic alphabetical icons #1287

Closed
lorrding opened this issue Jun 8, 2023 · 5 comments
Closed

[DISCUSSION] Add generic alphabetical icons #1287

lorrding opened this issue Jun 8, 2023 · 5 comments
Labels

Comments

@lorrding
Copy link
Contributor

lorrding commented Jun 8, 2023

About this discussion

As far as I know, we don't have any generic letter icons.

It could be useful to have a set of generic icons that are not bound to any app but could be used as a way to temporarily cover one that is not yet supported or linked to apps that uses a letter.

The first thing that comes to my mind could be apps like Google that users could bind to generic_G until we have an actual icon for it (obviously we already have in this case).
Some apps also just have a letter for their icons. A great example is the Numworks app. Their app icon is just a big N, so instead of making a new icon with a name like numworks.app we could just link to the generic_N icon.

Think of theses like the generic gallery/calculator/message/contact icons we already have.

@everypizza1
Copy link

This would help with some Adobe apps.
Screenshot_20230822-171507.jpg

@x9136
Copy link
Collaborator

x9136 commented Nov 22, 2023

@SuperDragonXD Say there are 26 alphabetical icons. What will they be linked to or organized in the overall appfilter.xml structure? A separate section with an empty package?

@SuperDragonXD
Copy link
Contributor

SuperDragonXD commented Nov 22, 2023

Most of them won't be mapped in appfilter.xml itself (to prevent issues with launchers and dummy apps), but they could be added in a custom generic_map.xml with all the generic icons/apps:

app/assets/generic_map.xml
…
  <item component="" drawable="generic_G" name="G" />
  <item component="" drawable="generic_G_lower" name="g" />
  <item component="" drawable="generic_camera" name="Camera" />
…

@x9136
Copy link
Collaborator

x9136 commented Nov 27, 2023

Half of the task is done. You can take the icons as is or improve them, and then move on to implementation.

@x9136
Copy link
Collaborator

x9136 commented Oct 7, 2024

I added 26 letters of the alphabet, so I consider the task completed.

To simplify the installation of these icons, you need to refine Lawnchair: LawnchairLauncher/lawnchair#4880

@x9136 x9136 closed this as completed Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

5 participants