infinite loop in threadedclient.py when server closes websocket

[tweber]

I am using geventclient.py which subclasses WebSocketClient in threadedclient.py. The client connects and waits for a message. If the server sends a message and immediately closes the websocket, the client goes into an infinite loop. It happens in threadedclient.py in the _receive() method. Basically, there is a socket recv() command which returns "" indicating that the server has closed. But the _receive() method does not close, and calls socket recv() again. Here is the first part of the function with my patch, which fixes the problem in my limited tests.

def _receive(self):
    next_size = 2
    try:
        self.sock.setblocking(1)
        while self.running:
            if self.__buffer:
                bytes, self.__buffer = self.__buffer[:next_size], self.__buffer[next_size:]
            else:
                bytes = self.read_from_connection(next_size)

            ######### patch start
            if bytes is None or len(bytes) == 0:
                self.server_terminated = True
                self.running = False
                break
            ######### patch end

            with self._lock:
                s = self.stream
                next_size = s.parser.send(bytes)

[Lawouach]

Hello there, I think you're running an older version of ws4py. Would you mind trying with the latest? I'll try to investigate on my side as well.

[Lawouach]

This is indeed an old release of ws4py. I advise you to upgrade to the latest release. Thanks.