Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bashisms #32

Open
Yamakaky opened this issue Apr 3, 2016 · 3 comments
Open

Bashisms #32

Yamakaky opened this issue Apr 3, 2016 · 3 comments

Comments

@Yamakaky
Copy link

Yamakaky commented Apr 3, 2016

Your shell scripts use #!/bin/sh, but it should be #!/bin/bash. On my computer, sh is a link to dash and not bash, so some bash features are not supported.
http://manpages.ubuntu.com/manpages/natty/man1/checkbashisms.1.html
While I'm here, you should take a look to http://redsymbol.net/articles/unofficial-bash-strict-mode/, it's really useful. And #!/usr/bin/env bash is even better.

@lethosor
Copy link
Member

lethosor commented Apr 3, 2016

Which scripts do you mean? I know I've successfully tested distro_fixes.sh with dash and zsh many times. (Maybe you're using an outdated version, though - if you haven't, try grabbing the latest copy from this repo.)

@Yamakaky
Copy link
Author

Yamakaky commented Apr 3, 2016

Sorry, the script comes from the aur package.

@Yamakaky Yamakaky closed this as completed Apr 3, 2016
@Yamakaky
Copy link
Author

Yamakaky commented Apr 4, 2016

In fact, the problem is present in the package downloadable at http://lazynewbpack.com/linux/. Maybe make a release?

@Yamakaky Yamakaky reopened this Apr 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants