Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite WikibaseIntegrator #184

Closed
2 tasks done
LeMyst opened this issue Aug 22, 2021 · 0 comments · Fixed by #152
Closed
2 tasks done

Rewrite WikibaseIntegrator #184

LeMyst opened this issue Aug 22, 2021 · 0 comments · Fixed by #152
Assignees
@LeMyst
Labels
enhancement New feature or request help wanted Extra attention is needed v0.12.x
Milestone
v0.12

Comments

@LeMyst
Copy link
Owner

LeMyst commented Aug 22, 2021 •
edited
Loading

Will probably break compatibility 🤷

TODO

  • Rewrite BaseDataType and Datatypes
  • Re-add the __select_item() who search item in SPARQL DB (named get_items/get_item)

Rewrite FastRunContainer

  1. Get data for entity
  2. If needed, get data for labels, descriptions and aliases
  3. Compare fastrun data from item data
  4. Return a boolean if write is required or not, stop on first write required
@LeMyst LeMyst self-assigned this Aug 22, 2021
@LeMyst LeMyst linked a pull request Aug 22, 2021 that will close this issue
⚡Rewrite WikibaseIntegrator #152
Merged
3 tasks
@LeMyst LeMyst pinned this issue Aug 22, 2021
@LeMyst LeMyst added enhancement New feature or request help wanted Extra attention is needed v0.12.x labels Aug 22, 2021
@LeMyst LeMyst added this to the 0.12 milestone Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeMyst LeMyst

Labels
enhancement New feature or request help wanted Extra attention is needed v0.12.x
Projects
None yet
Milestone
v0.12
Development

Successfully merging a pull request may close this issue.

⚡Rewrite WikibaseIntegrator LeMyst/WikibaseIntegrator
1 participant
@LeMyst