New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.12.0: write_required returns True when no write is required #380

Open

dpriskorn opened this issue Jul 19, 2022 · 3 comments

Contributor

dpriskorn commented Jul 19, 2022

code is here https://github.com/internetarchive/wcdimportbot/blob/00dc45896d7e85e96f934bd13be2e9c6931cda17/src/models/wikibase/crud/update.py#L117

Contributor Author

dpriskorn commented Aug 23, 2022

I could try to provide a few lines reproducing the issue. Or a new test that fails.

Owner

LeMyst commented Aug 25, 2022

I'll check this next weekend.

Contributor Author

dpriskorn commented Nov 22, 2022 •

edited

Loading

James seems to have found a nice solution by simply comparing the json before/after😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment