Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazily copied inheritances #9

Open
IvanSanchez opened this issue Oct 21, 2015 · 2 comments
Open

Lazily copied inheritances #9

IvanSanchez opened this issue Oct 21, 2015 · 2 comments

Comments

@IvanSanchez
Copy link
Member

In order to save room, inheritances should be able to be lazily copied within the DOM via JS whenever the user expands them.

This might not be the preferred solution (docs should work without JS). Maybe this can be done via clever templates (output only names of inherited stuff, let the main HTML template have the JS to lazily load everything).

@mourner
Copy link
Member

mourner commented Oct 21, 2015

docs should work without JS

I would not be concerned here. Without JS, we can just gracefully degrade to linking the clickable inheritance headings to the original classes instead of expanding. Or just do nothing at all since docs would still be usable without JS (a user sees that a classes inherits Evented and then just goes on to check that class separately).

@mourner
Copy link
Member

mourner commented Sep 27, 2016

Let's prioritize this! The Leaflet 1.0 docs take an unreasonable time to load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@mourner @IvanSanchez and others