-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug in Polygon Tool after updating to Chrome 55 #655
Comments
Hi, for the first bullet point I think that it may be related to #618, which is rooted in a change in how chrome handles click/touch events, which is interfacing badly with Leaflet. I think this is actively being worked on in Leaflet's main branch but I'm not 100%. For your 2nd bullet point, I noticed that the maintainers of this project recently added ./dist/*.js etc. to the .gitignore which could possibly be messing with your styles? If that was the case, you probably wouldn't be able to load up the js either, though. We don't use the default draw toolbar styles so I'm not 100% on if they changed the styles recently, which would be a more likely explanation. |
Hi @z0d14c, about the first bullet point, I'll wait until the Leaflet Team came up with a solution. Until there, I'll make some workarounds in my code or temporarily disable the Polygon tool. For the second bullet point, I did not notice about .gitignore because I was picking up the CDN files. But the styles are not so important, I just wanted to show that difference, hehe. Tks for your help. Any progress I can make, I notice here. |
Styles didn't change much. The git changes were done to encourage using CDN's rather than direct links to the repository as well as fall in line with Leaflet's practices. The draw toolbar style was tweaked due to a chrome related bug. I'll take a look to see if that was patched. |
Chrome is now being truthy when asked if it's touch even if it's not. That's great. |
i believe my pull request may solve your problem #657 |
Tks guy's! I'll close this issue because in version 0.4.9, the bugs have been fixed. Thank you all!! |
How to reproduce
What behaviour I'm expecting and which behaviour I'm seeing
Minimal example reproducing the issue
jsBin (This is a basic example taken from the Leaflet Draw sample folder itself).
this example is as simple as possible
this example does not rely on any third party code
The text was updated successfully, but these errors were encountered: