Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Polygon Tool after updating to Chrome 55 #655

Closed
6 tasks done
DouglasOGarrido opened this issue Dec 12, 2016 · 6 comments
Closed
6 tasks done

Bug in Polygon Tool after updating to Chrome 55 #655

DouglasOGarrido opened this issue Dec 12, 2016 · 6 comments
Assignees
Labels

Comments

@DouglasOGarrido
Copy link

DouglasOGarrido commented Dec 12, 2016

  • I'm reporting a bug, not asking for help
  • I've looked at the documentation to make sure the behaviour is documented and expected
  • I'm sure this is a Leaflet Draw code issue, not an issue with my own code nor with the framework I'm using (Cordova, Ionic, Angular, React…)
  • I've searched through the issues to make sure it's not yet reported

How to reproduce

  • Leaflet version I'm using: 1.0.7
  • Leaflet Draw version I'm using: 0.4.7
  • Browser (with version) I'm using: Chrome 55.0.2883.87
  • OS/Platform (with version) I'm using: Windows 10 x64
  • Test in Chrome and then in Firefox to see the difference.

What behaviour I'm expecting and which behaviour I'm seeing

  • After updating Chrome 54 to Chrome 55, the Polygon tool stopping working. Started duplicating points (see the DIV's in HTML Dev Tools) and showing intersection errors that did not exist.
  • Another thing that changed was the Draw toolbar style.

Minimal example reproducing the issue

  • jsBin (This is a basic example taken from the Leaflet Draw sample folder itself).

  • this example is as simple as possible

  • this example does not rely on any third party code

@z0d14c
Copy link

z0d14c commented Dec 13, 2016

Hi, for the first bullet point I think that it may be related to #618, which is rooted in a change in how chrome handles click/touch events, which is interfacing badly with Leaflet. I think this is actively being worked on in Leaflet's main branch but I'm not 100%.

For your 2nd bullet point, I noticed that the maintainers of this project recently added ./dist/*.js etc. to the .gitignore which could possibly be messing with your styles? If that was the case, you probably wouldn't be able to load up the js either, though. We don't use the default draw toolbar styles so I'm not 100% on if they changed the styles recently, which would be a more likely explanation.

@DouglasOGarrido
Copy link
Author

Hi @z0d14c, about the first bullet point, I'll wait until the Leaflet Team came up with a solution. Until there, I'll make some workarounds in my code or temporarily disable the Polygon tool.

For the second bullet point, I did not notice about .gitignore because I was picking up the CDN files. But the styles are not so important, I just wanted to show that difference, hehe.

Tks for your help. Any progress I can make, I notice here.

@ddproxy
Copy link
Member

ddproxy commented Dec 14, 2016

Styles didn't change much. The git changes were done to encourage using CDN's rather than direct links to the repository as well as fall in line with Leaflet's practices.

The draw toolbar style was tweaked due to a chrome related bug. I'll take a look to see if that was patched.

@ddproxy
Copy link
Member

ddproxy commented Dec 14, 2016

Chrome is now being truthy when asked if it's touch even if it's not. That's great.

@ddproxy ddproxy self-assigned this Dec 14, 2016
@ddproxy ddproxy added the bug label Dec 14, 2016
@z0d14c
Copy link

z0d14c commented Dec 14, 2016

i believe my pull request may solve your problem #657

@DouglasOGarrido
Copy link
Author

Tks guy's!

I'll close this issue because in version 0.4.9, the bugs have been fixed. Thank you all!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants