Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbilityState::ready and friends should take actions by reference, not value #51

Open
alice-i-cecile opened this issue Jul 8, 2024 · 0 comments
Labels
usability Make the APIs easier to use
Milestone

Comments

@alice-i-cecile
Copy link
Contributor

Which feature is frustrating to use or confusing?

        let ability_id = ability_loadout.get_id(slot).unwrap();
        let ability = ability_manifest.get(ability_id).unwrap();
        let is_ready = ability_state.ready(ability.clone());

Expectation

This should take the ability by reference; there's no need to do otherwise.

@alice-i-cecile alice-i-cecile added the usability Make the APIs easier to use label Jul 8, 2024
@alice-i-cecile alice-i-cecile added this to the 0.9 milestone Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability Make the APIs easier to use
Projects
None yet
Development

No branches or pull requests

1 participant