Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Necessary dependencies from dev dependencies to dependencies #89

Closed
SleeplessOne1917 opened this issue Dec 7, 2022 · 0 comments · Fixed by #91
Closed

Move Necessary dependencies from dev dependencies to dependencies #89

SleeplessOne1917 opened this issue Dec 7, 2022 · 0 comments · Fixed by #91

Comments

@SleeplessOne1917
Copy link
Member

Currently if you want to use the client you have to import the following dependencies:

  • @sniptt/monads
  • class-transformer
  • node-fetch
  • reflect-metadata

In addition to this, I couldn't get my code to work with the latest version of node-fetch. I wouldn't have even thought to use a lower version of that specific dependency had I not seen the most recent issue before this one. I don't think it makes much sense to manually install dependencies that your dependencies depend on unless you happen to need to use them directly.

Fixing this should be as easy as moving the previously listed dependencies from devDependencies to dependencies in package.json and maybe pinning the correct version of node-fetch. I'll make a PR either on my lunch break or after work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant