Add clear() #310
Merged
Add clear() #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vweevers
commented
Oct 19, 2018
3 tasks
|
@ralphtheninja Updated. Could you have a look? Tests are yet to do, but I'd first like a review of the general approach, taking into account Level/memdown#191 and Level/level-js#174. |
vweevers
added
enhancement
|
|
||
| function warn (msg) { | ||
| if (typeof process !== 'undefined' && process && process.emitWarning) { | ||
| process.emitWarning(msg) |
ralphtheninja
approved these changes
Aug 14, 2019
|
Done. Tested against Level/memdown#191. |
|
Once Level/memdown#191 lands in master I'll make a canary branch there to run browser tests as well. |
vweevers
added a commit
to Level/memdown
that referenced
this pull request
Aug 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start of #236. For early feedback (see comments in code).