Add more range tests #353
Merged
Add more range tests #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vweevers
added
test
vweevers
commented
Oct 20, 2019
| reverseOpts, | ||
| expected.slice().reverse() | ||
| ) | ||
| } |
There was a problem hiding this comment.
This makes some tests (with reverse=true) redundant. We can remove those later, I figured that would be easier to review as a separate PR.
ralphtheninja
approved these changes
Oct 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To try and break Level/leveldown@fb7e970 of Level/leveldown#689.
Tested locally against
leveldown,memdownandlevel-js.