Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
write
,write-sorted
,write-random
into a singleput
benchmark (closes Merge write, -sorted and -random benchmarks into one #6, closes Don't use monotonic-timestamp for write-sorted benchmark #9), using options like--keys seq
to switch between random and sequential keys (as well as strings and buffers)crypto
(less blocking)write
, but unlikewrite-sorted
andwrite-random
which did not aggregate)Buffer.byteLength()
to compute total bytes written (closes Reported bytes written is incorrect (too low) #8)x.toFixed(3)
instead ofMath.floor(x)
Example of what this enables: compare write perf of sequential vs random keys:
Click to expand