From 74385f09a2ab63d0032784cf4933ed5e289d1f1b Mon Sep 17 00:00:00 2001
From: Vincent Weevers <mail@vincentweevers.nl>
Date: Sun, 26 May 2019 23:57:29 +0200
Subject: [PATCH] Add batch-put benchmarks

---
 README.md                |  10 +++
 benchmarks/batch-put.js  | 137 +++++++++++++++++++++++++++++++++++++++
 benchmarks/index.js      |   2 +
 benchmarks/write.js      |   4 ++
 benchmarks/write.plot.js |   1 +
 5 files changed, 154 insertions(+)
 create mode 100644 benchmarks/batch-put.js

diff --git a/README.md b/README.md
index 5192627..4f1269c 100644
--- a/README.md
+++ b/README.md
@@ -141,6 +141,16 @@ Perform concurrent `put()` operations on sorted string keys. Options:
 - `--concurrency`: default 10
 - `--valueSize`: size of value, as a number in bytes or string with unit (e.g. `--valueSize 1kb`)
 
+### `batch-put`
+
+Same as `write`, but in batches rather than singular puts. Perform concurrent `batch()` operations on random string keys and values. Options:
+
+- `-n`: amount of operations, default 1e6
+- `--batchSize`: default 1000
+- `--chained`: boolean flag, default false, use chained batch
+- `--concurrency`: default 1
+- `--valueSize`: size of value, as a number in bytes or string with unit (e.g. `--valueSize 1kb`)
+
 <!-- ### Other ideas
 
 - Write batches in different sizes (feature: define a matrix)
diff --git a/benchmarks/batch-put.js b/benchmarks/batch-put.js
new file mode 100644
index 0000000..1f41426
--- /dev/null
+++ b/benchmarks/batch-put.js
@@ -0,0 +1,137 @@
+'use strict'
+
+const crypto = require('crypto')
+const ldu = require('../lib/level-du')
+const keyTmpl = '0000000000000000'
+
+exports.defaults = {
+  benchmark: {
+    n: 1e6,
+    batchSize: 1e3,
+    concurrency: 1,
+    valueSize: 100,
+    chained: false
+  }
+}
+
+exports.plot = require('./write.plot')
+
+exports.run = function (factory, stream, options) {
+  stream.write('Elapsed (ms), Entries, Bytes, Last 1000 Avg Time, MB/s\n')
+
+  function make16CharPaddedKey () {
+    const r = Math.floor(Math.random() * options.n)
+    const k = keyTmpl + r
+
+    return k.substr(k.length - 16)
+  }
+
+  function start (db) {
+    const startTime = Date.now()
+    const batchSize = options.batchSize
+
+    let inProgress = 0
+    let totalWrites = 0
+    let totalBytes = 0
+    let timesAccum = 0
+    let elapsed
+
+    function report () {
+      console.log(
+        'Wrote', options.n, 'entries in',
+        Math.floor((Date.now() - startTime) / 1000) + 's,',
+        (Math.floor((totalBytes / 1048576) * 100) / 100) + 'MB'
+      )
+
+      stream.end()
+
+      db.close(function (err) {
+        if (err) throw err
+
+        ldu(db, function (err, size) {
+          if (err) throw err
+          if (size) console.log('Database size:', Math.floor(size / 1024 / 1024) + 'M')
+        })
+      })
+    }
+
+    function write () {
+      if (totalWrites >= options.n) return report(Date.now() - startTime)
+      if (inProgress >= options.concurrency) return
+
+      inProgress++
+
+      if (totalWrites % 100000 === 0) {
+        console.log('' + inProgress, totalWrites,
+          Math.round(totalWrites / options.n * 100) + '%')
+      }
+
+      // TODO: batchSize should be a multiple of 10
+      if (totalWrites % 1000 === 0) {
+        elapsed = Date.now() - startTime
+        stream.write(
+          elapsed +
+          ',' + totalWrites +
+          ',' + totalBytes +
+          ',' + Math.floor(timesAccum / 1000) +
+          ',' + (Math.floor(((totalBytes / 1048576) / (elapsed / 1000)) * 100) / 100) +
+          '\n')
+        timesAccum = 0
+      }
+
+      let start
+
+      if (options.chained) {
+        const batch = db.batch()
+
+        for (let i = 0; i < batchSize; i++) {
+          // TODO: see comment in write.js
+          const key = make16CharPaddedKey()
+          const value = crypto.randomBytes(options.valueSize).toString('hex')
+
+          batch.put(key, value)
+        }
+
+        start = process.hrtime()
+        batch.write(onWrite)
+      } else {
+        const ops = new Array(batchSize)
+
+        for (let i = 0; i < batchSize; i++) {
+          // TODO: see comment in write.js
+          const key = make16CharPaddedKey()
+          const value = crypto.randomBytes(options.valueSize).toString('hex')
+
+          ops[i] = { type: 'put', key, value }
+        }
+
+        start = process.hrtime()
+        db.batch(ops, onWrite)
+      }
+
+      function onWrite (err) {
+        if (err) throw err
+
+        const duration = process.hrtime(start)
+        const nano = (duration[0] * 1e9) + duration[1]
+
+        totalBytes += (keyTmpl.length + options.valueSize) * batchSize
+        totalWrites += batchSize
+        timesAccum += nano
+        inProgress--
+
+        process.nextTick(write)
+      }
+    }
+
+    for (let i = 0; i < options.concurrency; i++) write()
+  }
+
+  // TODO (once stream is sync): skip setTimeout
+  setTimeout(function () {
+    factory(function (err, db) {
+      if (err) throw err
+      start(db)
+    })
+  }, 500)
+}
diff --git a/benchmarks/index.js b/benchmarks/index.js
index 8d33d41..f8248c5 100644
--- a/benchmarks/index.js
+++ b/benchmarks/index.js
@@ -3,3 +3,5 @@
 exports.write = require('./write')
 exports['write-random'] = require('./write-random')
 exports['write-sorted'] = require('./write-sorted')
+
+exports['batch-put'] = require('./batch-put')
diff --git a/benchmarks/write.js b/benchmarks/write.js
index d532a47..dcbcaf1 100644
--- a/benchmarks/write.js
+++ b/benchmarks/write.js
@@ -75,6 +75,10 @@ exports.run = function (factory, stream, options) {
         timesAccum = 0
       }
 
+      // TODO: though we don't start the clock until after crypto.randomBytes(),
+      // due to concurrency there might be put() callbacks waiting in libuv
+      // while the main thread is blocked? hmz. Maybe use async randomBytes(),
+      // or pregenerated values (bonus: make them deterministic).
       const key = make16CharPaddedKey()
       const value = crypto.randomBytes(options.valueSize).toString('hex')
       const start = process.hrtime()
diff --git a/benchmarks/write.plot.js b/benchmarks/write.plot.js
index b77ca2f..53831d5 100644
--- a/benchmarks/write.plot.js
+++ b/benchmarks/write.plot.js
@@ -2,6 +2,7 @@
 
 const e = require('../lib/escape-gnuplot-string')
 
+// Note: also used by batch-put.js
 module.exports = function (title, description, results) {
   const durations = results.map(function (res, i) {
     const file = res.csvFile