Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove _setupIteratorOptions #74

Merged
merged 1 commit into from
Dec 25, 2018
Merged

Remove _setupIteratorOptions #74

merged 1 commit into from
Dec 25, 2018

Conversation

ralphtheninja
Copy link
Member

Closes #63

@vweevers
Copy link
Member

vweevers commented Dec 22, 2018 •
edited
Loading

LGTM but encoding-down doesn't have enough tests. Ideas:

  • Call abstract test suite with a factory that wraps memdown leveldown with encoding-down (but memdown hasn't been updated yet)
  • Test against flumeview-level (replace its level dependency using proxyquire)
  • Add iterator unit test on a mock down with custom serialization, assert that encoding + serialization is applied in the expected order

@ralphtheninja
Copy link
Member Author

Good points. Lets hold off with this PR for a while.

@vweevers vweevers mentioned this pull request Dec 25, 2018
Closed
30 tasks
@vweevers
Copy link
Member

Let's go ahead with this, following the new plan.

@vweevers vweevers merged commit cc24492 into master Dec 25, 2018
@vweevers vweevers deleted the iterator-options branch December 25, 2018 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vweevers vweevers vweevers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ralphtheninja @vweevers