-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs #141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!
Remaining concerns:
|
|
Regarding 4: one thing we can do is render a complete list into |
And when we have a |
| **Yoshua Wuyts** | [**@yoshuawuyts**](https://github.com/yoshuawuyts) | [**@yoshuawuyts@twitter**](https://twitter.com/yoshuawuyts) | | ||
| **Calvin Metcalf** | [**@calvinmetcalf**](https://github.com/calvinmetcalf) | | | ||
| **Nicholas Westlake** | [**@nrw**](https://github.com/nrw) | | | ||
| **Bryce Baril** | [**@brycebaril**](https://github.com/brycebaril) | [**@brycebaril@twitter**](https://twitter.com/brycebaril) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vweevers Now we're getting somewhere. Looks really nice!
"main": "index.js", | ||
"scripts": { | ||
"test": "standard && airtap --local --no-coverage test/index.js", | ||
"test-browsers": "standard && airtap --sauce-connect --loopback airtap.local --no-coverage test/index.js" | ||
"test-browsers": "standard && airtap --sauce-connect --loopback airtap.local --no-coverage test/index.js", | ||
"remark": "remark README.md CONTRIBUTORS.md -o" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does remark
know how each file should be processed and which plugin to apply to which output? CONTRIBUTORS.md
is completely generated, right? Just curious about the algorithm of this command, in which order things are done etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's pretty much the same as doing remark README.md && remark CONTRIBUTORS.md
. It'll use the same configuration, same list of plugins, but it creates a new processor (and plugin "instances") for each file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're wondering why remark-git-contributors
doesn't modify README.md
: because README.md
doesn't have a # Contributors
heading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aah ok. So I guess this means CONTRIBUTORS.md
has to exist and have an empty # Contributors
section at the very least.
@vweevers I'm guessing we are going to need our own custom tool, e.g. |
That's where I was going with |
We also want to use |
Aaaaaah! Now it makes even more sense 💡 |
Trying out some things, don't merge yet. Running
npm run remark
will regenerate the contributors section in the README.@ralphtheninja