Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak changelog #483

Merged
merged 6 commits into from
Jun 11, 2018
Merged

Tweak changelog #483

merged 6 commits into from
Jun 11, 2018

Conversation

ralphtheninja
Copy link
Member

@ralphtheninja ralphtheninja commented Jun 11, 2018

@ralphtheninja
Copy link
Member Author

ralphtheninja commented Jun 11, 2018

It's looking pretty neat now with links to users etc. We should probably do this in all repositories.

CHANGELOG.md Outdated

### Fixed
* Fix build problems on windows https://github.com/Level/leveldown/issues/247 (@obastemur)

- Fix build problems on windows [Level#247](https://github.com/Level/leveldown/issues/247) ([**@obastemur**](https://github.com/obastemur))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing parentheses around issue

CHANGELOG.md Outdated

### Fixed
* Fix build problems on windows https://github.com/Level/leveldown/issues/196 (@obastemur)

- Fix build problems on windows [Level#196](https://github.com/Level/leveldown/issues/196) ([**@obastemur**](https://github.com/obastemur))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing parentheses around issue

@vweevers
Copy link
Member

This is very nice indeed! I love remark :)

CHANGELOG.md Outdated
@@ -289,7 +289,7 @@

### Fixed

- Fix build problems on windows [Level#247](https://github.com/Level/leveldown/issues/247) ([**@obastemur**](https://github.com/obastemur))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I missed these is because they were plain urls and not in the #NR format.

@ralphtheninja ralphtheninja merged commit f8077cf into master Jun 11, 2018
@ralphtheninja ralphtheninja deleted the tweak-changelog branch June 11, 2018 13:07
@rvagg rvagg mentioned this pull request Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants