Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document chained batch #541

Closed
vweevers opened this issue Dec 9, 2018 · 2 comments
Closed

Document chained batch #541

vweevers opened this issue Dec 9, 2018 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@vweevers
Copy link
Member

vweevers commented Dec 9, 2018

We can copy some stuff from abstract-leveldown#chainedbatch.

In addition, make sure the sync option is documented in the right place (for both array batch and chained batch). See https://github.com/Level/leveldown/pull/540/files#r240022189.

@vweevers vweevers added the documentation Improvements or additions to documentation label Dec 9, 2018
@vweevers vweevers mentioned this issue Dec 9, 2018
@ralphtheninja ralphtheninja added this to the 5.0.0-rc1 milestone Dec 15, 2018
@ralphtheninja
Copy link
Member

Adding this to 5.0.0-rc1

@vweevers
Copy link
Member Author

Also change this part of the batch() docs, no longer true:

Any entries where the type is 'put' that have a 'value' of undefined, null, [], '' or Buffer.alloc(0) will be stored as a zero-length character array and therefore be fetched during reads as either '' or Buffer.alloc(0) depending on how they are requested.

It throws now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants