Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify minimum node version(s) with non-experimental N-API in package.json #547

Closed
vweevers opened this issue Dec 15, 2018 · 4 comments
Closed

Specify minimum node version(s) with non-experimental N-API in package.json #547

vweevers opened this issue Dec 15, 2018 · 4 comments
Milestone
5.0.0-rc1

Comments

@vweevers
Copy link
Member

Current:

leveldown/package.json

Lines 60 to 62 in b49194f

"engines": {
"node": ">=6"
}

@vweevers vweevers added this to the 5.0.0-rc1 milestone Dec 15, 2018
@ralphtheninja
Copy link
Member

I think we can use https://github.com/nodejs/node-addon-api and keep supporting node v6, but not sure. It would be great if we could get this out without pulling support for existing node versions.

@ralphtheninja
Copy link
Member

Some off github discussions led us to stop supporting node 6. It's soon reaching EOL anyway.

@mcollina
Copy link
Member

+1 in dropping Node 6 at this point.

@vweevers
Copy link
Member Author

Done in #552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0-rc1
Development

No branches or pull requests
3 participants
@mcollina @ralphtheninja @vweevers