Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy dependency #583

Merged
merged 1 commit into from
Jan 12, 2019
Merged

Remove legacy dependency #583

merged 1 commit into from
Jan 12, 2019

Conversation

peakji
Copy link
Member

@peakji peakji commented Jan 12, 2019

Remove the bindings module from dependencies since we are now using node-gyp-build to load NAPI bindings.

vweevers
vweevers approved these changes Jan 12, 2019
View reviewed changes
Copy link
Member

@vweevers vweevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch :)

@vweevers vweevers merged commit c8ab1f9 into Level:master Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vweevers vweevers vweevers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peakji @vweevers