Add linux-arm64, android-arm and android-arm64 prebuilds #587

vweevers · 2019-01-27T15:08:24Z

Closes #574, closes #360

vweevers · 2019-01-27T15:09:08Z

package.json

@@ -14,7 +14,11 @@
    "hallmark": "hallmark --fix",
    "dependency-check": "dependency-check . test/*.js bench/*.js",
    "prepublishOnly": "npm run dependency-check",
-    "prebuildify-cross-armv7": "prebuildify-cross --platform=linux --arch=arm --arm-version=7 -- -t 8.14.0 --napi --strip"
+    "prebuild-arm": "npm run prebuild-linux-arm && npm run prebuild-linux-arm64 && npm run prebuild-android-arm && npm run prebuild-android-arm64",


Should we shorten this with e.g. npm-run-all?

Yes, good idea. (TIL about it)

package.json

vweevers · 2019-01-27T15:37:11Z

prebuildify-cross fails on prebuildify-cross --platform=linux --arch=arm64 due to invalid args. ~~I think it needs --arm-version 8 (and that's a gap in the documentation)?~~

It hits this code branch: https://github.com/ahdinosaur/prebuildify-cross/blob/c4748f7fc5ad3e0e9bbadc6de2304528cf33406a/build#L90

vweevers · 2019-01-27T16:06:47Z

Args fixed in prebuild/prebuildify-cross@146cc6c and prebuild/prebuildify-cross@13bcaf2.

vweevers · 2019-01-27T18:48:38Z

To fix android-arm, we need to add a GYP_DEFINES environment variable with value target_arch=arm android_target_arch=arm host_os=linux OS=android to prebuildify-cross or yet-to-create docker images or prebuildify (as long as the env var ends up in node-gyp and thus gyp). Same for arm64.

Note:

OS must be uppercase
target_arch might not be necessary, because we're also passing an ARCH

This reverts commit 92bb36e.

ralphtheninja · 2019-01-27T23:56:46Z

@vweevers We got a segmentation fault in https://travis-ci.org/Level/leveldown/jobs/485175594#L1623 which is a bit worrying (nothing to do with the cross compiled stuff).

ralphtheninja · 2019-01-28T00:16:01Z

Gah. Travis borked of course. Restarting builds.

ralphtheninja

Approving my own changes :D

vweevers · 2019-01-28T07:47:22Z

We got a segmentation fault in https://travis-ci.org/Level/leveldown/jobs/485175594#L1623 which is a bit worrying (nothing to do with the cross compiled stuff).

Can you open an issue? Let's hope we can replicate + fix before 5.0.0

vweevers · 2019-01-28T07:47:49Z

I'll review later

vweevers · 2019-02-01T09:22:42Z

scripts/cross-compile

+#!/bin/bash
+
+DOCKER_USER="node"
+if [[ "$TRAVIS" == "true" ]]; then DOCKER_USER="travis"; fi


@ralphtheninja Can you explain the users? I'm guessing the working directory on the host is owned by travis, and docker must use the same user? Can't we change permissions instead?

I'm open to suggestions. If we don't do anything about the user (e.g. set USER in the Dockerfile) the container will run as root, thus producing binaries owned by root. Which leaves us with two options (as I see it):

either we do something related to user, i.e. run the container with the correct user

keep running the container as root, but copy out the binaries from the container, which is done in prebuildify-cross

Thinking about it some more, I think I prefer 2. since the docker image doesn't need any specific users. This needs some tweaking to the cross-compile script as well. Also need to look into how prebuildify-cross does this with output folders etc.

I liked the initial approach of running as the node user. Why did that not work?

Because it runs as user with uid 1000 and the jenkins user is 2000.

Because it runs as user with uid 1000 and the jenkins user is 2000.

*travis user? 😉

Alright, I'm fine with both the current solution and the alternative, copying out the binaries. ~~The latter would also remove the npm i problem (#587 (comment)), because if we copy out the binaries then we don't have to mount any volume.~~ ignore me, it's late

Yes, travis user. I don't know where jenkins came from. Jenkins! Get out of my head!

It's not a perfect solution, but it works. Lets tweak it as we go?

scripts/cross-compile

vweevers · 2019-02-01T09:23:30Z

scripts/cross-compile

+if [[ "$TRAVIS" == "true" ]]; then DOCKER_USER="travis"; fi
+
+exec docker run -u ${DOCKER_USER} --rm -it -v $(pwd):/app prebuild/${IMAGE} \
+     bash -c "npm i --ignore-scripts && npx prebuildify -t 8.14.0 --napi --strip"


Seeing as each invocation of this script runs in the same working directory, they all work against the same node_modules, and reinstall each time. Can we A) skip that or B) mount node_modules as a named volume, so that changes in the docker guest are hidden from the host?

Does npx use a locally installed bin if available, or does it always install the latest version of prebuildify?

Can we A) skip that

Not sure what you mean by that. Unsure what you mean here, mind writing snippet that explains the changes you want to make?

Afaik, npx uses a locally installed .bin if available. If it didn't, we wouldn't be able to use the specific branch of prebuildify we need to override e.g. platform.

Not sure what you mean by that.

npm i.

Unsure what you mean here, mind writing snippet that explains the changes you want to make?

I'll elaborate. We can either A) skip npm i in docker. We simply reuse what's already installed on the host. That only works (safely) in Travis though, where both host and guest are Linux. Not when testing things locally (on Mac, Windows or a different Linux flavor). That's also why the current approach is less than ideal, because after npm run prebuild-arm, you're stuck with a node_modules meant for a different platform.

So option B is to use a named volume. An anonymous volume may also work. Something like docker run -v $(pwd):/app -v :/app/node_modules. Initially, Docker will copy the existing /app/node_modules into the second volume. From then on, any changes to node_modules (e.g. by npm i) are applied to the second volume, meaning they don't affect node_modules on the host.

Afaik, npx uses a locally installed .bin if available. If it didn't, we wouldn't be able to use the specific branch of prebuildify we need to override e.g. platform.

👍

vweevers · 2019-02-01T21:57:19Z

I can't approve my own PR so LGTM

Add linux-arm64, android-arm and android-arm64 prebuilds

579b4c6

vweevers requested a review from ralphtheninja January 27, 2019 15:08

vweevers commented Jan 27, 2019

View reviewed changes

5.0.0-2-arm

99aaf92

vweevers commented Jan 27, 2019

View reviewed changes

package.json Outdated Show resolved Hide resolved

vweevers changed the title ~~Add linux-arm64, android-arm and android-arm64 prebuilds~~ Add linux-arm64, android-arm and android-arm64 prebuilds [wip] Jan 27, 2019

vweevers mentioned this pull request Jan 27, 2019

Create android-arm and android-arm64 images prebuild/docker-images#2

Closed

ralphtheninja added 18 commits January 27, 2019 20:33

Disable package-lock.json

92a2b3b

Disable android for now

b384ab5

Use plain docker for linux and armv7/arm64

b886ee8

Print out file type after build

821a9fa

5.0.0-2-docker

aba704b

Print out users and groups

c38859c

Print out environment

53e8575

Only do linux-armv7 for now

92bb36e

Run docker with user travis on Travis

12c43df

5.0.0-2-docker2

db6e652

Revert "Only do linux-armv7 for now"

fac4027

This reverts commit 92bb36e.

Clean up

14c3c44

Update arm64 script

43c07af

5.0.0-2-docker3

9c76803

Add back android armv7

e057ee6

5.0.0-2-docker4

6ea1cba

Add back android arm64

08e0d59

5.0.0-2-docker5

1435e49

ralphtheninja added 3 commits January 28, 2019 01:00

Actually run prebuild-android-arm64

b513742

5.0.0-2-docker6

7112fe1

Refactor into cross-compile script + remove prebuildify-cross dependency

51c4cfb

Revert temporary version

d48e9dd

ralphtheninja changed the title ~~Add linux-arm64, android-arm and android-arm64 prebuilds [wip]~~ Add linux-arm64, android-arm and android-arm64 prebuilds Jan 28, 2019

ralphtheninja approved these changes Jan 28, 2019

View reviewed changes

ralphtheninja mentioned this pull request Jan 28, 2019

Release v5.0.0-3 so we can test android binaries #588

Closed

ralphtheninja mentioned this pull request Jan 28, 2019

Investigate segfault #589

Closed

vweevers commented Feb 1, 2019

View reviewed changes

scripts/cross-compile Outdated Show resolved Hide resolved

vweevers commented Feb 1, 2019

View reviewed changes

Remove -it

dfd15d6

ralphtheninja merged commit f1d4c7c into master Feb 1, 2019

ralphtheninja deleted the prebuild-arm-flavors branch February 1, 2019 22:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add linux-arm64, android-arm and android-arm64 prebuilds #587

Add linux-arm64, android-arm and android-arm64 prebuilds #587

vweevers commented Jan 27, 2019 •

edited by ralphtheninja

Loading

vweevers Jan 27, 2019

ralphtheninja Jan 27, 2019

vweevers commented Jan 27, 2019 •

edited

Loading

vweevers commented Jan 27, 2019 •

edited

Loading

vweevers commented Jan 27, 2019 •

edited

Loading

ralphtheninja commented Jan 27, 2019

ralphtheninja commented Jan 28, 2019 •

edited

Loading

ralphtheninja left a comment

vweevers commented Jan 28, 2019

vweevers commented Jan 28, 2019

vweevers Feb 1, 2019

ralphtheninja Feb 1, 2019

ralphtheninja Feb 1, 2019

vweevers Feb 1, 2019

ralphtheninja Feb 1, 2019

vweevers Feb 1, 2019 •

edited

Loading

ralphtheninja Feb 1, 2019 •

edited

Loading

ralphtheninja Feb 1, 2019

vweevers Feb 1, 2019

ralphtheninja Feb 1, 2019 •

edited

Loading

vweevers Feb 1, 2019 •

edited

Loading

vweevers commented Feb 1, 2019

Add linux-arm64, android-arm and android-arm64 prebuilds #587

Add linux-arm64, android-arm and android-arm64 prebuilds #587

Conversation

vweevers commented Jan 27, 2019 • edited by ralphtheninja Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vweevers commented Jan 27, 2019 • edited Loading

vweevers commented Jan 27, 2019 • edited Loading

vweevers commented Jan 27, 2019 • edited Loading

ralphtheninja commented Jan 27, 2019

ralphtheninja commented Jan 28, 2019 • edited Loading

ralphtheninja left a comment

Choose a reason for hiding this comment

vweevers commented Jan 28, 2019

vweevers commented Jan 28, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vweevers Feb 1, 2019 • edited Loading

Choose a reason for hiding this comment

ralphtheninja Feb 1, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ralphtheninja Feb 1, 2019 • edited Loading

Choose a reason for hiding this comment

vweevers Feb 1, 2019 • edited Loading

Choose a reason for hiding this comment

vweevers commented Feb 1, 2019

vweevers commented Jan 27, 2019 •

edited by ralphtheninja

Loading

vweevers commented Jan 27, 2019 •

edited

Loading

vweevers commented Jan 27, 2019 •

edited

Loading

vweevers commented Jan 27, 2019 •

edited

Loading

ralphtheninja commented Jan 28, 2019 •

edited

Loading

vweevers Feb 1, 2019 •

edited

Loading

ralphtheninja Feb 1, 2019 •

edited

Loading

ralphtheninja Feb 1, 2019 •

edited

Loading

vweevers Feb 1, 2019 •

edited

Loading