-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update prebuildify and node-gyp-build #625
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 27, 2019
Also closes #388. |
ralphtheninja
approved these changes
Apr 27, 2019
This comment has been minimized.
This comment has been minimized.
ARM ✔️ (took 5 min 58 sec)
Alpine ✔️ (took 1 min 35 sec)
|
vweevers
force-pushed
the
update-prebuilds
branch
from
April 28, 2019 13:47
0c5ad26
to
6d11ce6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tackles the final items of #575. Alpine and iOS are yet to do but we have a separate issues for those (#388 and #626). Supersedes #622.
Semver-minor because of the added
armv
tag.Once prebuild/docker-images#5 lands and is built+pushed, I'll temporarily modify our
.travis.yml
here to enable thearm
job without uploading prebuilds. IMO we don't have to smoke-test a release again.