Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prebuild-ci #324

Merged
merged 2 commits into from
Dec 9, 2016
Merged

add prebuild-ci #324

merged 2 commits into from
Dec 9, 2016

Conversation

juliangruber
Copy link
Member

This will make it so on every publish commit CI will upload the prebuilds to GitHub releases, so there's going to be automatic prebuilds for all OS / Node combinations we support, without manual work necessary.

@vweevers
Copy link
Member

vweevers commented Dec 7, 2016

@juliangruber For this to work, we need to remove shallow_clone: true from appveyor.yml.

@juliangruber
Copy link
Member Author

@juliangruber For this to work, we need to remove shallow_clone: true from appveyor.yml.

just read up on that, not sure why that would be a problem?

@vweevers
Copy link
Member

vweevers commented Dec 7, 2016

The working directory will not be a git working tree if shallow_clone is true (Appveyor downloads a tarball from GitHub).

@juliangruber
Copy link
Member Author

ok, I understand. I guess it's worth it though, trading build times for automatic prebuilds, right?

@juliangruber
Copy link
Member Author

@vweevers bump

@vweevers
Copy link
Member

vweevers commented Dec 8, 2016

LGTM.

@juliangruber
Copy link
Member Author

@vweevers can you set PREBUILD_TOKEN as an env var on appveyor for this? Travis has it already

@vweevers
Copy link
Member

vweevers commented Dec 9, 2016

@juliangruber done

@juliangruber juliangruber merged commit 36457ad into master Dec 9, 2016
@juliangruber juliangruber deleted the add/prebuild-ci branch December 9, 2016 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants