Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade nan, prebuild(-install), add node 11 #596

Merged
merged 4 commits into from
Mar 2, 2019
Merged

Conversation

vweevers
Copy link
Member

We can publish this as 4.0.2. The nan upgrade might fix compilation for Mac users, pending feedback on #595 (comment).

In case it doesn't, the prebuild and prebuild-install upgrade (incorporating prebuild/prebuild#234) means we can at least publish prebuilds for node 11.

If that doesn't work, then let's just get v5 out the door 😄

@vweevers vweevers added the semver-patch Bug fixes that are backward compatible label Feb 23, 2019
@vweevers vweevers marked this pull request as ready for review February 23, 2019 13:48
@vweevers
Copy link
Member Author

Side note: GitHub's Draft feature is awesome. Let's get rid of the WIP app?

@ralphtheninja
Copy link
Member

Side note: GitHub's Draft feature is awesome. Let's get rid of the WIP app?

@vweevers I don't know how the draft feature work, but if you like it, do it 😄

@vweevers vweevers added the v4.x label Mar 2, 2019
@vweevers vweevers merged commit 37d00e9 into v4.x Mar 2, 2019
@vweevers vweevers deleted the v4.x-upgrade-nan branch March 2, 2019 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Bug fixes that are backward compatible v4.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants