Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what does del callback looklike #261

Closed
kevzettler opened this issue Jul 29, 2014 · 5 comments
Closed

what does del callback looklike #261

kevzettler opened this issue Jul 29, 2014 · 5 comments

Comments

@kevzettler
Copy link

https://github.com/rvagg/node-levelup#del

I don't see an example of the del callback what params does it take?

@dominictarr
Copy link
Contributor

function (err) { } I think it errors if there wasn't something to delete.

@juliangruber
Copy link
Member

@dominictarr iirc it doesn't, it errors for internal errors only

@dominictarr
Copy link
Contributor

oh, I was mistaken, there are tests to check it doesn't error.
https://github.com/rvagg/abstract-leveldown/blob/master/abstract/del-test.js#L58-L64

@juliangruber
Copy link
Member

do you guys think we should improve documentation here? it's so node idiomatic but at the same time we should have this as clear as possible

@kevzettler
Copy link
Author

couldn't hurt anything

@rvagg rvagg closed this as completed in 02bb5c3 Nov 15, 2014
rvagg added a commit that referenced this issue Nov 15, 2014
resolve #261, explain args to callback to #del
rvagg pushed a commit that referenced this issue Dec 25, 2014
Per bug report, example crafted from test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants