Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of rimraf #114

Closed
vweevers opened this issue Jan 6, 2018 · 5 comments
Closed

Get rid of rimraf #114

vweevers opened this issue Jan 6, 2018 · 5 comments
Assignees
@vweevers
Labels
cleanup Housekeeping

Comments

@vweevers
Copy link
Member

vweevers commented Jan 6, 2018

This was added in 001c86e, excluded from browser builds in 80822a7 and necessary because abstract-leveldown/testCommon.js requires rimraf.

I think we should solve this in abstract-leveldown so that memdown (and others) don't need these hacks. I'll open an issue. /cc @ralphtheninja
@vweevers
Copy link
Member Author

vweevers commented Jan 6, 2018

Actually I'll first test if the hacks are still required.

@vweevers
Copy link
Member Author

vweevers commented Jan 6, 2018

They aren't :) Looks like browserify is smart enough to respect the browser configuration of abstract-leveldown, and replace rimraf with an empty module.

@vweevers vweevers self-assigned this Jan 6, 2018
This was referenced Jan 6, 2018
Merged
Closed
@ralphtheninja
Copy link
Member

@vweevers So we can just remove the rimraf dependency now?

@vweevers
Copy link
Member Author

No, because of #116 (comment)

@vweevers vweevers added the cleanup Housekeeping label Jan 1, 2019
vweevers added a commit that referenced this issue Mar 29, 2019
@vweevers
Remove rimraf devDependency (closes #114)
155ca81
@vweevers
Copy link
Member Author

Done in #174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vweevers vweevers

Labels
cleanup Housekeeping
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ralphtheninja @vweevers