Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support constructing without location #95

Merged
merged 1 commit into from
Oct 13, 2019
Merged

Support constructing without location #95

merged 1 commit into from
Oct 13, 2019

Conversation

vweevers
Copy link
Member

@vweevers vweevers commented Oct 13, 2019

I wanted to send a PR to level-hookdown, to replace memdb with level-mem, but tests failed because level-hookdown uses the following pattern:

var mem = require('memdb')
var db = mem({ valueEncoding: 'json' })

Which is a reasonable expectation. On level-mem you'd have to do:

var mem = require('level-mem')
var db = mem(null, { valueEncoding: 'json' })

This PR fixes that but it ain't pretty. Long-term we should perhaps move location into options, at least in leveldown and friends.

@vweevers vweevers added enhancement New feature or request semver-minor New features that are backward compatible labels Oct 13, 2019
@vweevers vweevers merged commit 8f48baa into master Oct 13, 2019
@vweevers vweevers deleted the no-location branch October 13, 2019 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request semver-minor New features that are backward compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants