Support constructing without location #95
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to send a PR to
level-hookdown
, to replacememdb
withlevel-mem
, but tests failed becauselevel-hookdown
uses the following pattern:Which is a reasonable expectation. On
level-mem
you'd have to do:This PR fixes that but it ain't pretty. Long-term we should perhaps move
location
intooptions
, at least inleveldown
and friends.