-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move rocksdb to a git submodule #80
Comments
It was actually a bit after |
Now, I've never really used date := $(shell date +%F)
git_sha := $(shell git rev-parse HEAD 2>/dev/null)
gen_build_version = sed -e s/@@GIT_SHA@@/$(git_sha)/ -e s/@@GIT_DATE_TIME@@/$(date)/ util/build_version.cc.in Does anyone know how to do this? Without forgetting that it also needs to work on Windows. |
Umm, not really. But if it needs to be run before compiling and given it should work on windows. How does |
What's the benefit of defining these?
With CMake it seems: https://github.com/facebook/rocksdb/blob/50895e5f0dd293602b7ccb5d284e6143715a27e5/CMakeLists.txt#L124-L138 |
Yes, with Do you think that would make sense? On linux I think it wouldn't be a problem as we already have |
BTW, what does the use of submodules mean for npm-installed github dependencies? E.g. |
@vweevers It seems to work well. I tried with
At first I couldn't figure out why
Also, just noticed when typing this that |
@ralphtheninja why does it work though? leveldown has no postinstall step to initialize submodules; so is it a builtin behavior of npm? |
Good question. It must be imo. |
Yup, that's the case for npm 3.10, which logs:
npm 5.3 and 6.4 don't log this (or any other line containing |
OK, it's officially supported, see npm/npm#1876. It's not supported by yarn, however: yarnpkg/yarn#1488 |
Done in #141. |
So, I'm working on moving all dependencies to Git Submodules (as discussed in Level/leveldown#522), but I'm not quite able to figure out what the exact version of RocksDB is.
So, I know it's somewhere in
^5.3.0
, but no upstream tag (v5.3.3
tov5.3.6
) exactly matches the code in thedeps/leveldb/leveldb-rocksdb
folder.I guess I could try to find out the exact commit by digging into this a bit deeper (without 08fd9a3 I suppose), but would it be fine to upgrade to the latest
5.3
version (v5.3.6
) instead if tests pass?The text was updated successfully, but these errors were encountered: